scientist-softserv / adventist_knapsack

Apache License 2.0
1 stars 0 forks source link

styling looks off #307

Closed ShanaLMoore closed 5 months ago

ShanaLMoore commented 10 months ago

Summary

Logo looks too big.

Are the footer links in the correct position?

Theme is not implemented?

Are the styles not getting loaded?

Testing Instructions

NOTE: Please ask a dev about compiling assets on staging before QA'ing this ticket

Acceptance Criteria

The general look and feel should match adventist proper's staging

Screenshots

Image

Image

STAGING

Image

Image

KatharineV commented 8 months ago

Team, I'm hopping on this existing ticket to report that Knapsack tenants are showing me center-justified text, but our proper sites have left-justified. I looked for a place where this might be a style choice I could toggle on/off, but I didn't see it. If it's a bug, I'm adding a note here, since it seems related to styling to me?

Knapsack metadata display:

Image

ADL prod metadata display:

Image

laritakr commented 8 months ago

@jillpe should this be pulled back to rework the show pages, or should that be a new ticket?

KatharineV commented 7 months ago

Another piece of weird styling revealed itself today. A collection homepage is showing the title in white font on a white background with raised text shadows. Usually, Hyku only shows me this view if I try to upload a banner to a collection page (and I never do that because the feature breaks collections so they can't be edited).

First screenshot below shows a Knapsack collection with weird homepage styling. Second screenshot shows the expected font look on a collection homepage with no banner image.

Image

Image

ShanaLMoore commented 5 months ago

I'm going to make separate tickets for the additional issues.