scientist-softserv / adventist_knapsack

Apache License 2.0

1 stars 0 forks source link

:gift: create overrides for the catalog controller for Adv search builder vs iiif catalog search builder and for dog biscuits translations #318

Closed ShanaLMoore closed 10 months ago

ShanaLMoore commented 10 months ago

Story

create overrides for the catalog controller for Adv search builder vs iiif catalog search builder and for dog biscuits translations

There are some things in the catalog controller that belong in hyku and some in adventist. It is not clear which is which.

Goal is to figure out the commented out to-do's

Acceptance Criteria

[ ] We have figured out what to do with commented out to-do's and new tickets are created

Screenshots / Video

Testing Instructions and Sample Files

Notes

ShanaLMoore commented 10 months ago

Extra context

there were some things in the catalog controller that belonged in hyku and some that belonged to adv. rob wasn't sure which one belonged to which. rob left a bunch of comments w todos for things he hasn't figured out yet.

he does not know what happens if you override the catalog controller, you shouldn't have to copy blacklight into it again. Not sure how to override catalog controller.

ShanaLMoore commented 10 months ago

maybe helpful for the idea that hyku needs to have this be configurable

https://github.com/samvera-labs/allinson_flex/blob/main/app/controllers/concerns/allinson_flex/dynamic_catalog_behavior.rb