scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

exclude thumbnail derivatives from displaying in the UV #429

Closed ShanaLMoore closed 1 year ago

ShanaLMoore commented 1 year ago

Summary

TN.jpg files are being rendered in the UV.

Per Katharine,

"Can we exclude thumbnails from showing in the UV? As in this example, it loads first and it creates a confusing user experience."

Acceptance Criteria

Screenshots or Video

link to example: https://adl.s2.adventistdigitallibrary.org/concern/published_works/20214381_an_appeal_to_the_youth_funeral_address_of_henry_n_white?locale=en

image

Testing Instructions

Ask katharine or jeremy how to import a thumbnail file.

Update per Jeremy:

The thumbnail file is imported via the OAI importer. You can create an OAI import with: metadataPrefix: “oai_adl” set: “adl:thesis” URL: http://oai.adventistdigitallibrary.org/OAI-script And limit the import to one or two (the first and second record has a thumbnail).

After that, visit the work's show page/UV and verify that the file ending with TN.jpg shows up in the items section, but not in the UV

Notes

jeremyf commented 1 year ago

Recommendation: Skip thumbnail in feed (attaching it to the work), Generate from primary file instead.

The consequence of this would mean we completely ignore any pre-generated thumbnails. If that is not acceptable, we have some work that can re-purpose existing thumbnails and attach them to the archival PDF.

ShanaLMoore commented 1 year ago

Dev notes:

scenario (data already exists)

option 1: We can either clean up the data. query solr for filenames that end in .TN.jpg, delete and eradicate them. Change bulkrax to not import them.

option 2: change the manifest to skip anything that has a filename that ends with .TN.jpg etc.

We a choosing to override the manifest. (option 2 as it is the easier lift)

Spacestone may handle when data does not exist. Then option 1 can be handled then too.

DiemBTran commented 1 year ago

blocked, staging adl tenant is busted

ShanaLMoore commented 1 year ago

removed blocked label. try testing using the sdapi tenant

DiemBTran commented 1 year ago

This passes SoftServ QA: See attached screenshot.

tested on:

The file ending with TN.jpg shows up in the items section, but not in the UV ![Thesis An Investigation of the Syntax of Words Denoting Time in the New Testament ID 20121820_an_investigation_of_the_syntax_of_words_denoting_time_in_the_new_t Hyku 2023-04-05 at 11 24 59 AM](https://user-images.githubusercontent.com/29311858/230170852-d1c76081-6514-431b-a397-b85023e17d5f.jpg) ![Thesis An Investigation of the Syntax of Words Denoting Time in the New Testament ID 20121820_an_investigation_of_the_syntax_of_words_denoting_time_in_the_new_t Hyku 2023-04-05 at 11 24 49 AM](https://user-images.githubusercontent.com/29311858/230170871-25c17b23-5d4e-415c-91e1-6cad06aacce5.jpg)
ShanaLMoore commented 1 year ago

cc @KatharineV for client QA, you'll want to use the sdapi tenant after we reindex it. We plan on doing so tonight. Otherwise we can provide videos or screenshots if you'd like a faster review.

KatharineV commented 1 year ago

Tested on SDAPI staging and found that thumbs are excluded from the UV. Hooray! Thank you.

KatharineV commented 1 year ago

Tested this ticket on production with a Book uploaded as Published Work on 2023-03-30. The book has a thumbnail in the Items list, but it does not show in the UV. All is working as expected.

Image

Image