scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

Remove automatic collection creation from Adventist Entry #438

Closed jeremyf closed 1 year ago

jeremyf commented 1 year ago

In our <2023-02-28 Tue> meeting, we agreed to stopping the auto-matic collection creation by way of the part and part_of properties. This was creating all kinds of heartburn and head-aches. We still need to have collection creation for non-part/part_of properties.

See the following document for details: https://docs.google.com/document/d/1Cckk2kDbZ9V9f-D--DW0hIF5R3ykeRH4XFgJ6RyPsYU/edit#heading=h.j2x8gqss93ii

Testing Instructions

Ideally, you are starting from a relatively "clean" repository of data; because any existing works associated with collections will not be disassociated those collections.

The part_of is the title of a collection. But it is the parents value that creates the connection to the collection. Depending on when this is reviewed, we may introduce a Facet link for the part_of value (that is link to the catalog with a prepopulated search term).

Note 1: Given that we've been importing from OAI regularly, it is possible that the 20000026 record will already be associated with a collection. In that case the checkbox for note 1 cannot be verified; but the other line items can be verified.

Related to scientist-softserv/adventist_knapsack#439

jillpe commented 1 year ago

SoftServ QA: PASS

URL test

Screenshots below ![Image](https://user-images.githubusercontent.com/84697174/223858879-dabb1e59-0f10-43d2-b71d-67ceed353eda.png) ![Image](https://user-images.githubusercontent.com/84697174/223858888-2763f208-89b6-4f01-ad6e-1709a179f82f.png) ![Image](https://user-images.githubusercontent.com/84697174/223858895-714d8ae5-d0a6-4431-b9e8-fed5a0b3cc6e.png) ![Image](https://user-images.githubusercontent.com/84697174/223858902-d682b137-e813-4d07-a7f0-ce464138b299.png)
KatharineV commented 1 year ago

I followed the testing instructions on ADL and SDAPI staging. As Jeremy suggested, previous OAI imports meant that the parent collection link persisted for collection 20000026. So, I ran a larger import on SDAPI staging where fewer periodicals have been brought in. My importer is here, and collection 20000075 provides evidence that the parent collection link is no longer populating.

In the screenshot below, note that "Part of" reads "Jubilee Standard," but there is no parent collection link.

Image

KatharineV commented 1 year ago

I tested this ticket on production, and I can confirm that collection 20000026 has the correct "part of" metadata. The (incorrect) parent collection was already populated from a previous import.