scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

[3] Enable CSV parser enabled in Bulkrax #481

Open DiemBTran opened 1 year ago

DiemBTran commented 1 year ago

Summary

The librarians would like to use a CSV parser to import works, and would like that to be enabled in Bulkrax.

Acceptance Criteria

Note: this originally had the acceptance criteria of "CSV Parser is enabled in Bulkrax for new mappings". However in conversations during 2022-10-24 sprint planning, we acknowledged that both the CSV parser and the OAI QDC parser would have the same mappings. The mappings are tracking in scientist-softserv/adventist-dl#152 ([3]DC term metadata mapping) and the OAI QDC parsing is tracking in scientist-softserv/adventist-dl#182 ([5] Fix OAI QDC import). The idea being that if we get the mapping right for the CSV parser we get the mapping right for the OAI QDC parser.

Screenshots or Video

Testing Instructions

Notes

Confused how to fill this out? Check out the playbook

DiemBTran commented 1 year ago

Linked items:

Relates to:

DiemBTran commented 1 year ago

Related MRs:

DiemBTran commented 1 year ago

Jeremy Oct 2022:


At present we have a custom OAI QDC Parser that could likely be removed in favor of the latest Bulkrax parser. Restoring the CSV Parser looks to be an adjustment of the ./config/initializers/bulkrax.rb.

DiemBTran commented 1 year ago

This passes SoftServ QA: See attached screenshot.

tested on:


In the drop-down for parsers, you should see two options:

CSV and OAI parsers are enabled in Bulkrax. Mappings will be addressed in scientist-softserv/adventist-dl#152([3]DC term metadata mapping)

Image

DiemBTran commented 1 year ago

Needs further review:

  1. When selecting the Parser, selecting CSV should not display the Parser, Base url, Metadata prefix, or Set (source) fields. Those fields should only display for OAI parsers
  2. Visibility, Rights statement, and Override rights statement appear twice on the form. New Importer Adventist Digital Library 2022-11-07 at 4 03 29 PM

per the slack conversation, this should not be. jeremy stated that the fix is most likely in main but not pushed to staging yet.

KatharineV commented 1 year ago

Looks good on staging and production.