scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

🧹 Handle slugs #50

Closed laritakr closed 12 months ago

laritakr commented 12 months ago

Story

Refs https://github.com/scientist-softserv/adventist_knapsack/issues/287

Removes alternative_title from forms Removes alternative_title from bulkrax mappings

Additional Background: In the adventist implementation of slugs, the predicate "alternative" is being used to store the slug. If viewing the data, the predicate will contain the slug if there is one, and otherwise it contains the uuid.

A second term and predicate was added for slugs, but remediation of prior data into the new predicate has not yet happened, which would be beyond the scope of current work as it would require a data migration.

With the hyrax upgrade, alternative_title is now included by default. By removing the alternative_title from the any create or edit ability, the data for slugs is still saved in the same location as alternative_title would be, but does not impede any behavior.

Expected Behavior Before Changes

Work forms include alternative_title

Expected Behavior After Changes

Work forms do not include alternative_title

Screenshots / Video

**BEFORE, with and without a slug:** ![Screenshot 2023-10-04 at 1 57 55 PM](https://github.com/scientist-softserv/adventist_knapsack/assets/17851674/1d2f9582-9fc0-485d-bfe7-2c10905b6216) ![Screenshot 2023-10-04 at 1 59 21 PM](https://github.com/scientist-softserv/adventist_knapsack/assets/17851674/b2487f09-4ba0-452d-ac9a-b7c0b88edbcb)

Notes

laritakr commented 12 months ago

todo: verify that updated specs work.

ShanaLMoore commented 12 months ago

(prob not but asking anyways) - Will this also solve the reason we can't delete works that have slugs? @laritakr

laritakr commented 12 months ago

(prob not but asking anyways) - Will this also solve the reason we can't delete works that have slugs? @laritakr

Hmmm I don't know. I didn't realize we couldn't! Is there a ticket for that?

ShanaLMoore commented 12 months ago

https://github.com/scientist-softserv/adventist_knapsack/issues/302

laritakr commented 12 months ago

scientist-softserv/adventist_knapsack#302

I have not addressed that, but I'll work on it next. This should have no effect on that issue.