search

scientist-softserv / adventist_knapsack

Apache License 2.0
1 stars 0 forks source link

Fully implement PDF.js toggle on/off #520

Open KatharineV opened 4 months ago

KatharineV commented 4 months ago

PDF.js functionality is partially available in the Adventist Hyku instance. Some of our tenants would benefit from using PDF.js as their primary viewer. We'd like to offer that option to them, so we want to fully implement the toggle on/off that is currently visible but not functional. We'd like tenants to be able to choose PDF.js and avoid all PDF splitting, if that is appropriate for their use case.

KatharineV commented 4 months ago

I noticed today that ADL's Knapsack testing environment doesn't include PDF.js. I expect this is because we started the Knapsack upgrade work before the team added PDF.js to serve as our interim PDF viewer. So, it makes sense for PDF.js to be missing from ADL's Knapsack. I am curious if fully implementing Knapsack will remove PDF.js and take us back to just the UV. Just wondering what to expect re: PDF.js when we finish the Knapsack move. @jillpe at one of our upcoming meetings could you let me know what to expect? Thank you!