scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

Search facet customizations missing from Knapsack #532

Closed KatharineV closed 5 months ago

KatharineV commented 10 months ago

Adventist Hyku has a customized action in the catalog view / search page where the Source and Type filters appear at the top of the facet menu. Both are automatically open when you visit the catalog or conduct a search. The customizations are not right on Knapsack. On Knapsack, only Source is open automatically, and it doesn't appear at the top of the page. We'd like to see at least the Source field moved to the top of the facets. It is less imperative that the Type field also be moved and set to auto-open. If we have to prioritize fixes, moving the Source field is the most important detail. Reinstating the existing customization for the Type facet is the secondary priority.

https://sdapi.b2.adventistdigitallibrary.org/catalog?utf8=%E2%9C%93&search_field=all_fields&q= Image

https://demo.adventist-knapsack-staging.notch8.cloud/catalog?utf8=%E2%9C%93&locale=en&search_field=all_fields&q= Image

Acceptance Criteria

Testing Instructions

From here Perform an empty catalog search by clicking "Go" Verify the facets and order matches Adventist proper's facet list

PS. If you see a facet category missing, it may be because we don't have any data that uses such property. Create a new work manually and fill in all the details.

NOTE

The carot icon to collapse/expand the facet (seen in adventist proper) is broken because of the bootstrap version change. I'd argue that should be fixed in a separate ticket.

ShanaLMoore commented 10 months ago

QA Results: Pass ✅ ⚠️

Tested on: Staging

knapsack Production
image image

⚠️ Note: I consider this a pass. The location facet is not available because there's no data with a location value. In knapsack staging this field does not populate. I'd consider this to be a separate bug ticket. I'd added the location facet check as an acceptance criteria on that ticket.

Update: this is a known bug in the hyku/hyrax community.

image

KatharineV commented 7 months ago

ADL QA: The facets on ADL knapsack staging look exactly as expected! Thank you!