scientist-softserv / adventist_knapsack

Apache License 2.0
1 stars 0 forks source link

Journal article custom field name not present on Knapsack #533

Closed KatharineV closed 2 months ago

KatharineV commented 7 months ago

In Adventist's version of Hyku, the Part Of field in the Journal Article work type shows with the label "Periodical." In Knapsack, that field still shows as "Part of." For consistency, we'd like this field updated to match the customized label.

See this work for example of field label "Part of": https://demo.adventist-knapsack-staging.notch8.cloud/concern/journal_articles/pur_2010_feb_pacific_union_recorder_february_2010?locale=en

See this work for example of field label "Periodical": https://sdapi.s2.adventistdigitallibrary.org/concern/journal_articles/pur_2010_feb_pacific_union_recorder_february_2010?locale=en

Same metadata for both examples above. Only the environment is different.

Acceptance Criteria

Testing Instructions

Either find or create a Generic Work. If new, be sure to fill in all required fields (and aark_id). Also fill in a value for "Part Of" and save. Visit the work's show page. The display of this value should have a label that says "Part Of".

Image

Either find or create a Journal Article. If new, be sure to fill in all required fields. Also fill in a value for the "Periodical" field and save. Visit the work's show page. The display of this value should have a label that says "Periodical".

Image

ShanaLMoore commented 7 months ago

This is interesting.

In attempts to reproduce this locally I created an sdapi article importer, limit 10. Both are from commit 2b50ce5.

Staging:

(says Periodical)

Image

Image

Locally:

(~correctly~ says Part Of)

Image

Image

NOTES

Update: I misunderstood the ask. We want it to say Periodical, right for feature parity? I'll update the acceptance criteria

ShanaLMoore commented 7 months ago

QA Results: Pass ✅

Tested on: Staging

Journal Article

The previous work linked by the client shows that Part Of has been updated to Periodical.

image

Generic Work

image

KatharineV commented 4 months ago

ADL QA: The label is updated on ADL knapsack staging. I created a new journal article and the field is correct. Thank you! https://adl.adventist-knapsack-staging.notch8.cloud/concern/journal_articles/08657fa2-95e2-4a35-8d47-9922c7f75427?locale=en