scientist-softserv / adventist_knapsack

Apache License 2.0
1 stars 0 forks source link

🦄 SPIKE: does default font Nobile shine through? #537

Closed ShanaLMoore closed 10 months ago

ShanaLMoore commented 10 months ago

Summary

does default font Nobile shine through? (Is Nobile displaying)

Workflow: Right-click and determine what font is showing in the inspection tool.

Acceptance Criteria

Screenshots or Video

Testing Instructions

Notes

ShanaLMoore commented 10 months ago

STAGING

Screenshot 2023-09-21 at 9 14 58 AM
ShanaLMoore commented 10 months ago

STAGING

When I visit the font tab and click to restore the font back to the original default, it's not Nobile.

Image

ShanaLMoore commented 10 months ago

When I change it to a distinct selection, I am unsure how it actually gets applied because the fonts don't look like it has changed anywhere in the views:

Image

image

ShanaLMoore commented 10 months ago

I think this feature is broken for Adventist so I don't think it's being loaded, but it never was to begin with.

In comparison, the following demo is from PALS:

image

image

RESTORE DEFAULT

image image

image

ShanaLMoore commented 10 months ago

I would not argue that this is something that broke from the hyku upgrade/knapsack change. This feature wasn't working to begin with.

Additionally, I've since discovered that $primary-font-family gets used by .product-feature on the homepage, which ADL does not have so I am closing this ticket. Additionally ADL if using it in the .jumbotron class which isn't being used anywhere in the app.

image image image
ShanaLMoore commented 10 months ago

Additionally ADL is using it in the .jumbotron class which gets called by the splash page. I have since discovered where that is being used and can verify that Nobile is loading.

image