scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

[1] Remove Universal Viewer constraint for showing only files with .obj. in them #602

Open DiemBTran opened 1 year ago

DiemBTran commented 1 year ago

Summary

Universal Viewer will not show files that lack the OBJ file naming convention. In our 2022-11-10 meeting, we discussed removing this constraint. This aligns with the shift in the Hyku application becoming the repository (and not just discovery layer) for the collection.

Context

See documentation for insight

The following code performs the selection:

https://github.com/scientist-softserv/adventist-dl/blob/b75626bc30c03642bd083c363c0fc0c52f38c6f8/app/services/hyrax/manifest_builder_service.rb#L25-L28

Here is the merge request that introduced the OBJ filter .

To complete: Revisit the above override file; remove the .obj. selection logic then compare against upstream Hyrax file (for v2.9.5 of Hyrax). If they are logically the same, then remove the override. Also remove the corresponding section in the readme.

Acceptance Criteria

Screenshots or Video

Testing Instructions

Create a work with two images: one that contains .obj. in the filename and another that does not. Before this change, when you look at the Universal Viewer (UV) for this file you should only see the file with the .obj.. After this change, when you look at this work, you should see both images in the UV.

Notes

Confused how to fill this out? Check out the playbook

DeonFranklin commented 1 year ago

Image