scientist-softserv / adventist_knapsack

Apache License 2.0
1 stars 0 forks source link

🐛 Ensure knapsack translations are first choice #63

Closed jeremyf closed 9 months ago

jeremyf commented 9 months ago

Prior to this change, assuming my default translation was "en" when I called the following—I18n.t('dog_biscuits.fields.date_issued')—I would get Translation missing: en.dog_biscuits.fields.date_issued.

We had added DogBiscuits into that path but we had not reloaded the back-end.

Further, the catalog controller was no longer doing useful work. The Rails.root is hyrax-webapp; which would already be working. For more on this anti-pattern, see Potential Issues Around Knapsack and Rails.root.

With this change, I have a small test to verify that dog biscuits translations are in fact loaded.

Related to: