☄️ Review Adventist's UI

[ShanaLMoore]

Summary

Adventist has gone through many updates as a result of upgrading their code to Valkyrie. Their UI will likely be impacted in a negative way.

dependent on

• [ ] #695 and
• [x] #696

Tasks

• [x] #745
• [ ] #744

Notes

[ShanaLMoore]

proprietor home page: local vs production

Click on the hamburger:

[ShanaLMoore]

proprietor page: local vs. prod

[kirkkwang]

I recommend doing one big ticket to get all the obvious UI wonkiness out of the way and then from then on make separate tickets for anything else that was missed.

[ShanaLMoore]

@kirkkwang Do you have any helpful related PRs you can link to this?

[jillpe]

Issues being seen might be related to the bootstrap version

[kirkkwang]

@ShanaLMoore not really, i don't remember the dashboard ever being messed up. Seems like we have some overrides going on because the dashboard should have looked fine.

[jillpe]

Blocked until more of the views are visible

[laritakr]

Work's show page breadcrumbs are incorrect... main_app.polymorphic_path(presenter) in Hyrax::BreadcrumbsForWorks returns nil, resulting in a link that goes nowhere. (Link is {tenant url}/concern/generic_works/?locale=en)

I believe that the final breadcrumb shouldn't even be a link... it is usually just be the text, but the polymorphic_path failure may cause a behavioral change.

(byebug) main_app.polymorhphic_path presenter
*** NoMethodError Exception: undefined method `polymorhphic_path' for #<ActionDispatch::Routing::RoutesProxy:0x0000ffff617f8670 @scope=#<Hyrax::GenericWorksController:0x00000000108330>, @routes=#<ActionDispatch::Routing::RouteSet:0x0000ffff692d73a0>, @helpers=#<Module:0x0000ffff6927b410>, @script_namer=nil>

Possibly related to https://github.com/scientist-softserv/amigos/issues/53?

[ShanaLMoore]

Closing. Client feedback should be captured and addressed in #744