scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

Iiif manifest is not generating correctly for universal viewer #730

Closed laritakr closed 1 month ago

laritakr commented 3 months ago

Story

When PDF files are split into multiple pages, they are expected to be viewable and searchable in the universal viewer. The manifest is not loading the canvas correctly.

Commit https://github.com/scientist-softserv/adventist_knapsack/pull/693/commits/630c7e54ad7de3b8aefb86b7eb11e061e264a873 introduced lonely operators which bypass the errors that were happening. Removing the lonely operators should allow finding what is missing.

Acceptance Criteria

Screenshots / Video

Manifest that is not working ``` { "@context": [ "http://www.w3.org/ns/anno.jsonld", "http://iiif.io/api/presentation/3/context.json" ], "type": "Manifest", "id": "https://cat.hyku.test/concern/datasets/a85de229-b43e-4d7f-816c-d4c57269a509/manifest", "label": { "none": [ "Another split attempt" ] }, "rights": "http://rightsstatements.org/vocab/InC-EDU/1.0/", "metadata": [ { "label": { "en": [ "Rights statement" ] }, "value": { "none": [ "In Copyright - Educational Use Permitted" ] } } ], "service": [ { "@context": "http://iiif.io/api/search/1/context.json", "profile": "http://iiif.io/api/search/1/search", "label": "Search within this manifest", "type": "SearchService1", "id": "https://cat.hyku.test/catalog/a85de229-b43e-4d7f-816c-d4c57269a509/iiif_search" } ], "items": [], "viewingHint": "paged", "rendering": [ { "@id": "https://cat.hyku.test/downloads/f2bf12d9-eaaa-4e7d-a878-b7fe5fa8e28e", "label": null, "format": "application/pdf" } ] } ```

Testing Instructions and Sample Files

Note

ShanaLMoore commented 2 months ago

QA RESULTS: ❌ NEEDS REWORK

TESTED ON STAGING

The image does not display in the UV even though it's attached to the work.

/manifest.json produces 500 internal server error:

Image

Image

locally:

items => [ ] there should be something in here

Image

laritakr commented 2 months ago

Need to rework how the viewers show.

Based on flipper setting and split status, we see:

ShanaLMoore commented 1 month ago

This issue will be covered and tested in #760