scientist-softserv / adventist_knapsack

Apache License 2.0

2 stars 0 forks source link

🐛 PDF.js doesn't load #731

Open ShanaLMoore opened 2 months ago

ShanaLMoore commented 2 months ago

Summary

[x] #726

PDF.js isn't loading.

The following was imported via oai bulkrax.

Acceptance Criteria

[ ] PDF.js should render PDFs

Testing Instructions

Feature flip to PDF.js. Via bulkrax or manually, import a PDF file. check the pdf.js viewer on the work's show page.

Notes

sjproctor commented 2 months ago

This is what I am getting when adding a PDF to a generic work.

kirkkwang commented 2 months ago

Hey @sjproctor the file set looks like a jpg, just wanted to double that if this was a actually a PDF or not.

ShanaLMoore commented 1 month ago

QA RESULTS: ✅ PASS

manual created work

When PDF.js is enabled and we attach a PDF file to a work:

bulkrax created works via OAI importer:

KatharineV commented 1 month ago

@laritakr just confirming, this ticket doesn't test the logic you were discussing the other day? This ticket is only about PDF.js behavior when the feature is flipped, not about testing PDF.js as the preliminary viewer before the UV kicks in?

laritakr commented 1 month ago

this ticket doesn't test the logic you were discussing the other day?

Correct. I am finishing up the work today to use PDF.js and UV as we discussed.

KatharineV commented 1 month ago

Works as expected on staging. Created this new work: https://adl.s2.adventistdigitallibrary.org/concern/conference_items/67eff180-3e9b-4f42-8192-363fefef841f?locale=en

Immediately after upload:

After refresh:

Flipped the feature back to UV and PDF.js was still present and working great with this work.