search

scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

Hide User Collection tag #791

Open ShanaLMoore opened 2 months ago

ShanaLMoore commented 2 months ago

Summary

Public show pages and collections in the catalog search have the "User Collection" and "Public" tag visible, when we have masked that in production. We still want that tag to be masked, please.

Acceptance Criteria

Screenshots or Video

staging displays unwanted tag from public show page

image

staging displays unwanted tag on catalog search results page

image

Production screenshot (public collection show) Image

Testing Instructions

Notes

The Acceptance Criteria was changed from only the User Collection tag to also include the Public tag. Approved by Katharine in Slack.

sjproctor commented 2 months ago

The Acceptance Criteria was changed from only the User Collection tag to also include the Public tag. Approved by Katharine in Slack.

Image Image

ShanaLMoore commented 2 months ago

QA RESULTS: ✅ PASS

tested on STAGING

I no longer see the tags on the public show page or in the catalog search results

Image

Image

Image

They're only present on the admin dashboard collection index page:

Image

KatharineV commented 2 months ago

To see feature parity, I compared the Dykes collection on Staging and Production.

The User Collection and Public tags are masked, as expected.

Now that the banner image works on staging, however, I see that some white text was probably always present on staging but wasn't visible. The "Created by" field is showing (and is blank) on staging. That field doesn't show on production. Can we hide it? Especially since it is blank? Maybe that means it falls under another ticket.

Staging shows blank "created by:" Image

Production doesn't show that field at all: Image

KatharineV commented 2 months ago

771 might be related to the blank "created by" field that is showing?

ShanaLMoore commented 2 months ago

@KatharineV Yes, that should be resolved when #771 gets into staging.