scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

Collection branding doesn't work #797

Open ShanaLMoore opened 2 months ago

ShanaLMoore commented 2 months ago

Summary

Update re: collection branding. ref

Team, I know that the banners are broken on collection pages (or at least they have been in our instance from day one). Logos used to work on production, but in staging I tested and the logo will upload but then the page is frozen. It won't even save and update to show me if the logo renders properly. I just tested with the following collection, but it won't save my changes, so you won't see much if you go there I'm afraid: https://adl.s2.adventistdigitallibrary.org/dashboard/collections/ebbab001-fd0c-40f2-ab26-eebab8808392/edit?locale=en#branding

I tested all the branding options and none of them work on staging post-Valkyrie. We'd like the logos to work at least, if possible.

Acceptance Criteria

Screenshots or Video

Image

Testing Instructions

On Staging, find this collection in admin dashboard > collections Click on edit go to the branding tab, upload an image for

![image](https://github.com/user-attachments/assets/124c84ba-3cdb-4961-b21b-a83313d07d13)

Notes

ShanaLMoore commented 2 months ago

QA RESULTS: ✅ PASS

tested on STAGING

I uploaded a banner, logo, and thumbnail. I filled in alt text and link url when available.

Image

public view of collection

Image

Image

KatharineV commented 1 month ago

All features appear to function! https://adl.s2.adventistdigitallibrary.org/collections/9c5feb14-7c90-499f-aa4e-ea5cf40baf2d?locale=en