scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

Can't migrate or save records with Based Near #851

Open ShanaLMoore opened 1 month ago

ShanaLMoore commented 1 month ago

Summary

We tried to lazy migrate this record with an edit/save.

When opening the record, London was the based near value. We tried to save it and got an error.

After returning back to the edit page, the values looked strange and were were never able to successfully save or migrate this record.

Image

Image

Maybe related? Another location error was spotted when we tried editing this record

Image

I was able to edit this record by adding a location, but received an error on save.

When I went back to the edit page for this record, I received the same rdf_subject error.

Going back to the show page gives me a record not found error.

Image

Creating a new work with a location field also fails.

Creating new works in demo.hyku-demo saved just fine so this issue may be specific to Adventist.

Acceptance Criteria

Image

Testing Instructions

Create a work with a location and save. Edit that work and save. Find an old work with a location, edit and save.

Notes

related? https://github.com/samvera/hyrax/pull/6790/files

ShanaLMoore commented 1 month ago

Do we need to add this for the resources?

  # Fetch remote labels for based_near. You can remove this if you don't want
  # this behavior
  include Hyrax::IndexesLinkedMetadata
ShanaLMoore commented 1 month ago

Per LaRita, this is also a problem for Pals knapsack.

ShanaLMoore commented 1 month ago

TODO:

based_near not working for collection, generic work, and image work types in adventist knapsack. However it works in Hyrax and Hyku.