scientist-softserv / adventist_knapsack

Apache License 2.0
2 stars 0 forks source link

Ensure that viewers show rather than thumbnails #890

Closed laritakr closed 1 week ago

laritakr commented 1 week ago

Story

Refs:

In the case of a split work, :pdf? needs to be included in the methods checked on a presenter. In the case of a work that isn't split, Valkyrie has changed the term we use to check for a .pdf suffix. It appears that we do not fill in the label term. If characterization fails and we fall back to looking for a pdf, we needed to look in the right location.

Expected Behavior Before Changes

When PDF.js is selected via flipper and a work has been split, it sometimes just shows a thumbnail. When PDF.js is selected via flipper and work is not split, it sometimes just shows a thumbnail.

Expected Behavior After Changes

In new (valkyrie) resources, resources converted from Fedora, and works still in Fedora:

Screenshots / Video

Both of these originally showed thumbnails only ![Screenshot 2024-11-13 at 2 51 37 PM](https://github.com/user-attachments/assets/0dbc51c1-a365-4b1a-a79d-3ce33d9d718d) ![Screenshot 2024-11-13 at 2 47 01 PM](https://github.com/user-attachments/assets/43050ab0-1783-4136-bd53-321cff20efc9)

Notes