scientist-softserv / adventist_knapsack

Apache License 2.0
1 stars 0 forks source link

♻️ Remove dog biscuits show attributes #93

Closed jeremyf closed 8 months ago

jeremyf commented 8 months ago

Ref https://github.com/scientist-softserv/adventist_knapsack/issues/242 Addresses metadata issues by moving as closely as possible to standard Hyrax views.

Notes

I looped through the DogBiscuits config to find the properties and then compared what was in the ./app/views/hyrax/base/_attribute_rows.html.erb to adjust and amend. I looked to the dog biscuits generated attribute_rows partials to see how to render the different fields.

%i[conference_item
  dataset
  exam_paper
  journal_article
  published_work
  theses
].flat_map do |model|
  DogBiscuits.config.send("#{model}_properties")
end.uniq
Screenshots # Publication Status is now saved and appears on show page ![Screenshot 2023-10-16 at 7 50 59 PM](https://github.com/scientist-softserv/adventist_knapsack/assets/17851674/4ac2d897-75fb-4594-a889-ed4408052982) # Rights notes and access notes now appear on form and show page for all work types ![Screenshot 2023-10-16 at 8 08 34 PM](https://github.com/scientist-softserv/adventist_knapsack/assets/17851674/7d9a0625-6c0b-4e93-970c-3fabc60288b6)
laritakr commented 8 months ago
laritakr commented 8 months ago

Everything looks good other than: