search

scientist-softserv / amigos

0 stars 0 forks source link

✅ Spec coverage for Hyrax::Resource with dynamic loading need to be written #20

Closed ShanaLMoore closed 2 weeks ago

ShanaLMoore commented 3 weeks ago

Summary

Add specs that covers dynamic loading for Hyrax::Resource

Parent Ticket

Base work off of the WIP PR

Acceptance Criteria

Screenshots or Video

Testing Instructions

Notes

ShanaLMoore commented 3 weeks ago

This will test that the module is included. ✅

We also need to test the module itself.

ShanaLMoore commented 2 weeks ago

TODO: since Rob was still developing, please recheck the coverage is adequate cc @kirkkwang

kirkkwang commented 2 weeks ago

Handled in this commit https://github.com/samvera/hyrax/commit/44b75f9656cd610a34707af97a9aa7ba9158831b

kirkkwang commented 2 weeks ago

Reverted the spec in this commit https://github.com/samvera/hyrax/commit/4275dbce53f44f336ac2964bf3f02b3bfa1c3d9a

The spec was causing flaky issues and really felt unnecessary because it was simply testing an if statement