scientist-softserv / britishlibrary

Other
3 stars 0 forks source link

Importer status changes from complete to complete (with failures) #292

Open grahamjevon opened 1 year ago

grahamjevon commented 1 year ago

In this instance, an importer will initially say that the import is "complete". This will give the user the impression that the import has finished and everything is ok. However, the status will subsequently change to "complete (with failures)." This is an issue if the user believes that importer completed successfully and does not check again. Presumably the status should continue to say "pending" until the process is 100% finished. At this point the status can be updated definitively to say either "complete", "complete (with failures)", etc.

I noticed while testing the importer titled "20230221_GJ_Sarah_BM_test" on staging. This importer was "complete (with failures)" because five works (rows) contained data in the funder_1 column. These 5 rows therefore failed to import (see issue #222).

The issue is not that the importer status should not end as "complete (with failures)". The issue is that the status should not suggest that it is "complete" before ending as "complete (with failures)".

This might be linked to issue #132 (where importers continue to say "pending" despite being complete).

cziaarm commented 1 year ago

Still an issue (after Bulkrax updates)?

grahamjevon commented 11 months ago

This is still an issue. Screenshot below shows the status as "while" it is still process, then changing to "complete (with failures)" once it has finished processing.

Image

Image

https://bl.bl-staging.notch8.cloud/importers/118

grahamjevon commented 11 months ago

I wonder if it is the appearance of records in the "Entries Failed" column that is triggering the status to switch prematurely to "complete" while still processing?

I just watched a successful import on bl-demo, refreshing the page while the importer was processing and the status expectedly remained at "pending" until the importer had successfully processed everything. At which point the status changed to "complete". This was all as expected.