scientist-softserv / britishlibrary

Other
3 stars 0 forks source link

🐛 UV Download option - error message #429

Closed jillpe closed 1 year ago

jillpe commented 1 year ago

Summary

reference:

When I try to download a jpg, I get an error message.

Image

Image

Acceptance Criteria

Testing Instructions

On staging, visit this work/UV Click on the download button at the bottom of the the UV. see screenshot below A user should be able to download any options available there, successfully.

BEFORE:

image

AFTER: Only the high res option should be available. A user should be able to download it without errors.

jillpe commented 1 year ago

User was logged in

ShanaLMoore commented 1 year ago

While starting this, we wondered if this option should even be available. Considering an option for high vs low resolution, we'd imagine a user would always select the higher one. So, would it be ok if we removed the low res option? The high res one is working as expected. The lift to do so would be much smaller. cc @grahamjevon @j-basford

ref: https://assaydepot.slack.com/archives/C0313NK2LJ0/p1684950442467519

grahamjevon commented 1 year ago

Hi @ShanaLMoore - we are happy to proceed with the smaller option. I just replied to that effect to Jill in Slack - copying that message here: "Hi @Jill, we can't think of a reason it is needed so we are happy to take the easy option and remove it. If a reason for its existence does emerge in the future, we can cross that bridge then."

DiemBTran commented 1 year ago

This passes SoftServ QA: See attached screenshots.

tested on:

Only the high res download option is available ![mola bl-staging notch8 clouduvuv html#manifest=mola bl-staging notch8 cloudconcernarticles3a3e4542-ec27-4748-93ea-3fad5a0c3b05manifest config=mola bl-staging notch8 clouduvuv-config json 2023-05-26 at 1 21 04 PM](https://github.com/scientist-softserv/britishlibrary/assets/29311858/92f7a66c-820f-43ec-8c02-900034b97514) ![default jpg (3102×4340) 2023-05-26 at 2 22 40 PM](https://github.com/scientist-softserv/britishlibrary/assets/29311858/cd662319-6fcb-4e09-a2e3-7fe23e50a657)
grahamjevon commented 1 year ago

This does not pass BL QA. I added a work on staging and when I try to download the page in UV, I still get the same error.

Image

When I try to download the "(jpg)" option I get the error below. When I try to download the "(?)" option, it downloads successfully.

Image

kirkkwang commented 1 year ago

@grahamjevon That's weird, i purposefully hid that option and when i visited your page I don't see it, i'm curious how you're seeing it. Can you refresh or open it in an incognito/private mode? I'm curious if you have a cached version of the config file that was changed.

image
grahamjevon commented 1 year ago

@kirkkwang It seems I don't see it in Edge, but I do see it in Chrome

Image

kirkkwang commented 1 year ago

@grahamjevon can you try incognito mode in Chrome? I'm thinking it's a caching issue if Chrome is your main browser.

grahamjevon commented 1 year ago

@kirkkwang It looks like you are right - I don't see this option in incognito mode

kirkkwang commented 1 year ago

@grahamjevon thanks for checking that, unfortunately there's not much we can do about a user's cached data, it'll just have to expire on its own or get cleared. If that is the situation, does this pass QA?

grahamjevon commented 1 year ago

yes - I'll pass it through. Thanks @kirkkwang