scientist-softserv / britishlibrary

Other
3 stars 0 forks source link

🎁 UV Download option - question mark #430

Closed jillpe closed 1 year ago

jillpe commented 1 year ago

Summary

ref:

Should this "?" be replaced with something more definite?

Image

Acceptance Criteria

jillpe commented 1 year ago

related to #429

kirkkwang commented 1 year ago

I have this a point and a feature, looks like this isn't a bug we introduced, even with this Brighton Museum example, if you click on the download, you'll see the ?.

https://collections.brightonmuseums.org.uk/records/5e8ae448b93ca100176aa8ab

This example was provided by Ed Silverton from the UV Slack channel

DiemBTran commented 1 year ago

This passes SoftServ QA: See attached screenshot.

tested on:

The download option now says "(jpg)" instead of "?" ![mola bl-staging notch8 clouduvuv html#manifest=mola bl-staging notch8 cloudconcernarticles3a3e4542-ec27-4748-93ea-3fad5a0c3b05manifest config=mola bl-staging notch8 clouduvuv-config json 2023-05-26 at 1 21 04 PM (1)](https://github.com/scientist-softserv/britishlibrary/assets/29311858/dc42f4b0-c10d-4c2c-84b5-2b54b1529614)
grahamjevon commented 1 year ago

This does not pass BL QA. I added a work with a jpeg on staging and I can still see the ? in the download option.

Image

kirkkwang commented 1 year ago

@grahamjevon again i'm seeing something different than you are

I'm sure we're on the same link as well. Can you check this and the other ticket again?

image