scientist-softserv / hykuup_knapsack

container project for the Hyku Up deploy of Hyku
Apache License 2.0
1 stars 0 forks source link

:bug: CollectionResources x Thumbnails: Alt text doesn't work #205

Closed ShanaLMoore closed 3 months ago

ShanaLMoore commented 5 months ago

Summary

Acceptance Criteria

Screenshots or Video

collections can no longer upload a thumbnail. After creating a collection, a user used to be able to upload a thumbnail on edit.

![image](https://github.com/scientist-softserv/hykuup_knapsack/assets/10081604/880d0ab3-a883-43c8-b0bd-1c7fc3c842ed) It should look like: ![image](https://github.com/scientist-softserv/hykuup_knapsack/assets/10081604/9649216f-6466-4b30-af8c-37b08446f689)

Testing Instructions

image

Results checklist

(verifying both branding AND default thumbnails, since they interact)

Notes

ref:

ShanaLMoore commented 5 months ago

https://samvera.slack.com/archives/CA8ANGLEL/p1714575345096909

Image

ShanaLMoore commented 4 months ago

We will implement this the way that collection logos and banners got implemented.

ref: https://github.com/samvera/hyrax/commit/22f0d64703fc306fbcff0cbb3b0358d84a3196c3#diff-69953ce87573380937a88812d601159110a97da5b1621ebc79b7460f0cbb3ae5

ShanaLMoore commented 4 months ago

BLOCKED from QA until Shana updates testing instructions

ShanaLMoore commented 4 months ago

QA Results: Needs Rework ❌

Uploading branding images are not loading in the UI.

Example: https://demo.hyku-demo.notch8.cloud/dashboard/collections/5cd101a4-e698-4141-8c02-8976e14efe49?locale=en

Image Not Found error message. This works locally so I think it's a server issue. I tried adding a persistent volume in this PR

These two paths needs to be symlinked:

Image

Image

ShanaLMoore commented 4 months ago

UPDATED: the latest deploy renders the upload, but the thumbnails still don't show

Image

Image

ShanaLMoore commented 4 months ago

The issue seems to be whatever is responsible for indexing thumbnail_path_ss

staging data:

 "thumbnail_path_ss"=>"/app/samvera/branding/5cd101a4-e698-4141-8c02-8976e14efe49/thumbnail/eddie-baby.jpg",

this should remove app/samvera

jillpe commented 3 months ago

SoftServ QA: ❌ Needs Rework - saved alt text does not display in various pages

'Thumbnail' section is present in the branding tab ✅ ![Image](https://github.com/scientist-softserv/hykuup_knapsack/assets/84697174/4e854312-99a3-4a25-af0f-f3a0b5fd7027)

Collection Created

thumbnail displays but the alt text is not present in the dashboard collection page view, public collection show page view, or the catalog search view. The catalog search results thumbnail also overlaps text ❌ ![Image](https://github.com/scientist-softserv/hykuup_knapsack/assets/84697174/be00474e-2c28-43d1-af05-884e1de1d3e3) ![Image](https://github.com/scientist-softserv/hykuup_knapsack/assets/84697174/98e35505-9061-448b-80c0-74018855c411) ![Image](https://github.com/scientist-softserv/hykuup_knapsack/assets/84697174/62d79958-fa14-42b1-8132-c2313e29c069)
ShanaLMoore commented 3 months ago

Image

jillpe commented 3 months ago

Blocked until knapsack is updated

jillpe commented 3 months ago

SoftServ QA: ✅

Image

Image

Image

ShanaLMoore commented 3 months ago

issues noticed internally when QA-ing collection branding. client verification is not needed.