scientist-softserv / hykuup_knapsack

container project for the Hyku Up deploy of Hyku
Apache License 2.0
1 stars 0 forks source link

:bug: Valkyrie: double_combo FileSet Derivatives don't get copied over #206

Closed ShanaLMoore closed 1 week ago

ShanaLMoore commented 2 months ago

Summary

⚠️ Reference this branch for your base, if it hasn't already been merged into main. ⚠️ [ this branch has since been merged ]

While LaRita was working on the derivative issues in IiifPrint, she noticed that we missed the mark when implementing file sets for valkyrie in the double_combo!

Currently, we are copying over the thumbnail for the fileset but none of its derivatives. That means that they will be lost during the lazy migration (fedora => valkyrie on a record save). We must fix this.

Collection thumbnails (currently handled about the same as a derivative) should be migrated via a rake task, as Collection thumbnails are no longer supported in Hyrax.

Hopefully we can leverage what LaRita has learned by working on this ticket:

Acceptance Criteria

Screenshots or Video

Testing Instructions

Notes

this is a duplicate of https://github.com/samvera/hyrax/issues/6791 - the work will need to go into Hyrax.

ShanaLMoore commented 1 month ago

TODO

update freya adapater to find the derivatives in addition to the thumbnails.

laritakr commented 1 month ago

Pull request is in draft, pending some way of testing it... https://github.com/samvera/hyrax/pull/6807