scientist-softserv / louisville-hyku

Other
0 stars 0 forks source link

[2] Rendering thumbnails #146

Closed orangewolf closed 1 year ago

orangewolf commented 1 year ago

Summary

Thumbnails are not rendering properly on Staging:

Screenshot ![Screen_Shot_2022-02-01_at_8.47.21_AM](/uploads/ec95618b78f92eece7cfdbddd24619d6/Screen_Shot_2022-02-01_at_8.47.21_AM.png)

When you click into a work, if there's an image it will display in the UV, but the items thumbnails below are still not rendering.

Screenshot ![Screen_Shot_2022-02-01_at_8.49.11_AM](/uploads/6e22a502f486338866ba797ee9146795/Screen_Shot_2022-02-01_at_8.49.11_AM.png)

The thumbnails only appear to be rendering when you manually create a work, so I think this may mean a mapping is missing from bulkrax. Or it may be a bigger issue.

ie: I clicked on edit on one of the works and checked for a thumbnail field, but it didn't exist. That may mean the files aren't being saved properly?

OR... verify and confirm that some works don't have thumbnails (intentionally?)

Acceptance Criteria

orangewolf commented 1 year ago

Related Merge Requests

Updated uv rehash britishlibrary!

orangewolf commented 1 year ago

Shana February 2022

I am not convinced this is an issue anymore.

I uploaded the following sample files locally. By default, no thumbnail shows but when I click into edit the work and look at Representative Media, Thumbnail and Rendering options, I can see the jpg. the jpg is an attached file.

If I select it, then the work has a thumbnail. Perhaps we need a way to default it instead of manual selection. And, what should happen if there's no attached files?

Testing

in tmp directory, create a folder and put the following file in it: Cardinal_Text_HasParentMetadata.csv

Create a files directory and put the following file in it:

Image

Import with Upload from server path option, pointing to the csv.

Before

Image

Edit

Image

After

Image

orangewolf commented 1 year ago

Alisha February 2022

I agree that I don't think this is an issue.

I made an override for def iiif_viewer? in the "app/presenters/hyrax/work_show_presenter_decorator.rb " file on this pr that might be useful.