scientist-softserv / louisville-hyku

Other
0 stars 0 forks source link

172 skipped files #182

Closed alishaevn closed 1 year ago

alishaevn commented 1 year ago

Fixes #172

Present tense short summary (50 characters or less)

when a work is created with an identifier that doesn't end in an "s", then another work is created with the same identifier, but an "s" is added to the end...both works should be saved. it should also work vice versa.

adding custom slugs brought about additional validations. refer to the code comment for more on that.

co-author: @bkiahstroud co-author: @jeremyf co-author: @ShanaLMoore

Changes proposed in this pull request:

demo

two_up.zip

image

@samvera/hyku-code-reviewers

alishaevn commented 1 year ago

the "build/test/lint" pipelines are failing because of upgrading actions in #180. we're no longer letting a pipeline pass with failing specs. the failing specs are unrelated to any changes I've made in this pr though.

I have an open question about the direction here.

alishaevn commented 1 year ago
1. Can specs be added for this code?

I was thinking whether I wanted to do that in this pr or another. lol

2. Are there any other projects that use this same code that should be fixed similarly?

no idea. I feel like another app probably is using some custom slugs....but I can't say for sure.