Closed orangewolf closed 1 year ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Hey Rob, No, you can leave everything as is...the docker-compose.yml and docker-compose-production.yml files separate. We have several VMs running (a couple for testing and one that will be our production box). We can work with either setup. The problem we're having is getting fcrepo to start with the JAVA_OPTS settings using either of the dev or prod dc files. The settings do appear in the container, but fcrepo doesn't seem to be looking in the right place. Oh, I also didn't approve it because I left a password in the file on line #38. :\ Thanks!
git guardian is failing because of the SOLR_ADMIN_PASSWORD
value in the env. that value is in other repo's as well though, so it's not a merge halting factor.
the tests are already failing on main, but lint won't even run.
Randy - this needs some feedback from you.
1) we seperated out the production docker-compose from the dev one. This means on your server you'd change your docker-compose commands to
docker-compose -f docker-compose.production.yml
. We often set an alias on the server for this so thatdc='docker-compose -f docker-compose.production.yml'
2) we generally do not build the images on the production box, but instead build in CI and pull the images down. It looks like you probably have been building on the prod box. If you want to keep doing that, we can add support for building back in to the production docker-compose. Is that something you want?