Closed orangewolf closed 1 year ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
all of the code in this pr was merged into #187. this pr also contains work that's relevant to #173 and #174, but not #186.
Changes from #174 and #173 branches.
This PR includes the fix for the Leader Collection not searching searchable_text. We found that after the slugs feature was added that we needed to add the .to_param method to the work and the file_sets in order for the searchable_text to get passed through to it's parent for the results to then return. Ticket https://github.com/scientist-softserv/louisville-hyku/issues/173
This also add the ability for the collections to use searchable_text as well. Ticket https://github.com/scientist-softserv/louisville-hyku/issues/174
Since this PR also combines upstream changes form the Louiseville repo, there are 83 offenses detected. When prior to the rebase we had none. There are also several spec failing, that do not have to do with our work.
Screenshots:
CLICK ME Screenshots
Testing instructions: Signed in as an admin:
rapidly increasing
, which is part of the searchable_text of a child work.As a user: go to: https://louisville-hyku-staging.notch8.cloud/collections/ulua_leader?locale=en
rapidly increasing
, which is part of the searchable_text of a child work.