gitguardian[bot]
commented
1 year ago ⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [4917448](https://dashboard.gitguardian.com/incidents/4917448?occurrence=90557051) | Company Email Password | e52b21db7617226161b75c5367f82ffb434a5b19 | .env.development | [View secret](https://github.com/scientist-softserv/louisville-hyku/commit/e52b21db7617226161b75c5367f82ffb434a5b19#diff-da4c41d59c967338247b2f0ea6d845ab05171f942fd9521b96d3304202185db9R30) | | [4917448](https://dashboard.gitguardian.com/incidents/4917448?occurrence=90574768) | Company Email Password | 4fbcfb986dade39b5882abcfd77803f6b660c52e | .env.development | [View secret](https://github.com/scientist-softserv/louisville-hyku/commit/4fbcfb986dade39b5882abcfd77803f6b660c52e#diff-da4c41d59c967338247b2f0ea6d845ab05171f942fd9521b96d3304202185db9R30) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/company_email_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
alishaevn
Changes from #174 and #173 branches.
This PR includes the fix for the Leader Collection not searching searchable_text. We found that after the slugs feature was added that we needed to add the .to_param method to the work and the file_sets in order for the searchable_text to get passed through to it's parent for the results to then return. Ticket https://github.com/scientist-softserv/louisville-hyku/issues/173
This also add the ability for the collections to use searchable_text as well. Ticket https://github.com/scientist-softserv/louisville-hyku/issues/174
Since this PR also combines upstream changes form the Louiseville repo, there are 83 offenses detected. When prior to the rebase we had none. There are also several spec failing, that do not have to do with our work.
Screenshots:
CLICK ME Screenshots
Testing instructions: Signed in as an admin:
rapidly increasing, which is part of the searchable_text of a child work.As a user: go to: https://louisville-hyku-staging.notch8.cloud/collections/ulua_leader?locale=en
rapidly increasing, which is part of the searchable_text of a child work.