scientist-softserv / palni-palci

Other
1 stars 0 forks source link

Mediated Deposit Review - Depositor column mislabeled #444

Open crisr15 opened 1 year ago

crisr15 commented 1 year ago

Summary

The "depositor" column is mislabeled. Depositor currently links to creator. Instead the Depositor column should show the user name [Not user email] of the person who actually submitted the work.

Acceptance Criteria

Screenshots / Video

Image Creator in the screen shot below is easy to trace back as a creator and not a depositor.

Image

Testing Instructions

Notes

DiemBTran commented 1 year ago

This passes SoftServ QA: See attached screenshots.

tested on:

Depositor names display, instead of an email address or a work's metadata: creator ![Index Workflow Hyku Commons 2023-05-19 at 1 11 42 PM](https://github.com/scientist-softserv/palni-palci/assets/29311858/b9beca97-4864-498f-a748-5e8cc8f4885d) ![bold _italics_ title italics ID 5695bf94-39a1-42bd-b8bd-b013f775f204 Hyku Commons 2023-05-19 at 1 30 40 PM](https://github.com/scientist-softserv/palni-palci/assets/29311858/68f9b42f-1afa-4564-8cfe-308755118048) ![Index Workflow Hyku Commons 2023-05-19 at 1 28 36 PM](https://github.com/scientist-softserv/palni-palci/assets/29311858/13404026-4c4d-4e83-a478-f47a91be58f8) ![2023-05-19 2 tasks Mediated Deposit Review - Depositor column mislabeled #444 ID fecd51cb-3b3c-479f-8faf-c20219605f6a Hyku Commons 2023-05-19 at 1 30 54 PM](https://github.com/scientist-softserv/palni-palci/assets/29311858/52267e3c-63f0-4330-988a-2fb20c1d3bcf)
ndroark commented 1 year ago

In some repositories this change is working, in others (https://au-archives.hykucommons.org/admin/workflows?locale=en) I submitted a test work in an admin set with mediated deposit, and the queue shows "no data available in table" and depositors in the already published tab are still pulling from creator. Possibly related to #448 ?

labradford commented 1 year ago

https://github.com/scientist-softserv/palni-palci/pull/490

ndroark commented 1 year ago

In one tenant, newly deposited works not being added to the approval queue. Newly deposited work (https://nic2.commons-archive.org/concern/generic_works/dccec165-2513-4dd8-8213-b8bc1887c4aa?locale=en) shows "pending approval" status but the approval ribbon doesn't appear. Admin set currently using "one-step mediated deposit," though the "custom" workflow still appears as an option.

At least one other tenant is working as expected.

labradford commented 1 year ago

For this ticket I focused on the column name being mislabeled and I moved the workflow issues to ticket #448

ndroark commented 1 year ago

Got it. In that case it looks good.