search

scientist-softserv / palni-palci

Other
1 stars 0 forks source link

Remove Custom Mediated Deposit Workflow from options for Workflows on admin sets #448

Open crisr15 opened 1 year ago

crisr15 commented 1 year ago

Summary

Currently there are two options for mediated deposit in Palni/Palci, but both function the same. This is confusing for users and they should only have one options. Remove the Custom Mediated Depot Workflow for Hyku Commons from the options and leave only the one step mediated deposit workflow and default workflow.

Acceptance Criteria

Testing Instructions

Notes

aprilrieger commented 1 year ago

The script has already been run on staging and production to reassign the workflow 'hyku_commons_mediated_deposit' to 'one_step_mediated_deposit'.

labradford commented 1 year ago

Client reports that new works that are deposited into the new default workflow are not showing up on the Review Submissions tab

labradford commented 1 year ago

From Nic

Newly deposited works not being added to the approval queue. Newly deposited work (https://nic2.commons-archive.org/concern/generic_works/dccec165-2513-4dd8-8213-b8bc1887c4aa?locale=en) shows "pending approval" status but the approval ribbon doesn't appear. Admin set currently using "one-step mediated deposit," though the "custom" workflow still appears as an option.

labradford commented 1 year ago

from Nic

In some repositories this change is working, in others (https://au-archives.hykucommons.org/admin/workflows?locale=en) I submitted a test work in an admin set with mediated deposit, and the queue shows "no data available in table" and depositors in the already published tab are still pulling from creator. Possibly related to https://github.com/scientist-softserv/palni-palci/issues/448 ?

labradford commented 1 year ago

Did some research which led me to Hyrax app/services/hyrax/workflow/actionable_objects.rb but did not get further into my research to figure out if the problem is in this file.

summer-cook commented 1 year ago

Have been investigating this

NOTES:

when creating a test work with the One-Step Mediated deposit workflow it DOES appear in the notifications:

Screen Shot 2023-06-21 at 17 57 25

But does not appear in the "Review Submissions" tab/queue

summer-cook commented 1 year ago

This is not a problem for me in dev - the submission shows up normally. Possibly changes have not yet made it to prod?

image
crisr15 commented 1 year ago

@ndroark After doing some research we dont think this ticket is related to the work we did. And while looking at the other workflow error you were reporting with the 500 errors, I did some research on what was going on with the newest version of hyrax. That led me down a long path to this issue that was just added to the newest version of hyrax: https://github.com/samvera/hyrax/issues/5933. The solution for that seems like it may have broken our pagination in hyku, but that change accidentally got pulled into prod when we did the analytics upgrade. All of this is to say that the team is still working on this, but that its an isolated issue from the work we did on the workflow sprint. We may want to close this ticket and track changes on the new error ticket you made.

laritakr commented 6 months ago

@ndroark After doing some research we dont think this ticket is related to the work we did. And while looking at the other workflow error you were reporting with the 500 errors, I did some research on what was going on with the newest version of hyrax. That led me down a long path to this issue that was just added to the newest version of hyrax: samvera/hyrax#5933. The solution for that seems like it may have broken our pagination in hyku, but that change accidentally got pulled into prod when we did the analytics upgrade. All of this is to say that the team is still working on this, but that its an isolated issue from the work we did on the workflow sprint. We may want to close this ticket and track changes on the new error ticket you made.

This message seems to imply that there is another error ticket, and that this ticket was intended to be closed?

It appears that we need a clear list of exactly what we need to accomplish, as this ticket has so many conversations that it is unclear.

ndroark commented 6 months ago

We had done work previously so that new tenants are created with just the two workflows. Some older tenants still have three (example: https://butler.hykucommons.org/admin/admin_sets/admin_set%2Fdefault/edit?locale=en#workflow). Acceptance criteria for this ticket would be removing the "Custom mediated deposit workflow for Hyku Commons" as an option for any tenants in the system.

Will be prioritizing this quite low.

aprilrieger commented 4 months ago

Find all tenants that have workflow option: Custom mediated deposit workflow for Hyku Commons Remove Custom mediated deposit workflow for Hyku Commons as an option and set the default to the new/current default Default workflow

Image