scientist-softserv / palni-palci

Other
1 stars 0 forks source link

Put SSO tab behind feature flag #628

Open labradford opened 1 year ago

labradford commented 1 year ago

Story

Make sure the custom SSO tab in the admin panel is behind a feature flag before deploying to commons-archive

Acceptance Criteria

Testing

Click to expand to see a video tutorial. https://github.com/scientist-softserv/palni-palci/assets/29311858/bf7f317e-f024-49fe-b421-b9cdd24979ac

Notes

DiemBTran commented 1 year ago

This passes SoftServ QA: See attached screen recording. tested on:

Click to expand. SSO tab is behind feature flipper. https://github.com/scientist-softserv/palni-palci/assets/29311858/9935f6c4-ba68-4daa-a6fa-643b4266a7dd
ndroark commented 1 year ago

When I flipped the auth provider feature flipper to on began seeing a 500 error immediately. Error persists when trying to reload the dashboard.

Example: nic2.commons-archive.org group-nd.commons-archive.org

labradford commented 1 year ago

@ndroark I forgot to run the migrations when I deployed. Can you try again?

ndroark commented 1 year ago

Looks like that enabled it. I'll keep testing the other settings.

On Wed, Jul 26, 2023, 12:28 PM Lea Ann Bradford @.***> wrote:

@ndroark https://github.com/ndroark I forgot to run the migrations when I deployed. Can you try again?

— Reply to this email directly, view it on GitHub https://github.com/scientist-softserv/palni-palci/issues/628#issuecomment-1652144263, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4DJKR55SZSHUSFL3CBSBCDXSFAUVANCNFSM6AAAAAA2VZVF6I . You are receiving this because you were mentioned.Message ID: @.***>