scientist-softserv / palni-palci

Other
1 stars 0 forks source link

Add Favicon to Hyku Commons homepage #829

Open ndroark opened 1 year ago

ndroark commented 1 year ago

Summary

Pals would like to be able to have a home page favicon for [Hyku Commons[(https://hykucommons.org/) set up through html.

Tasks

The app/helpers/hyrax_helper.rb has a favicon method; which does not appear to be called in app/views/_head_tag_extras.html.erb nor app/views/hyrax/homepage/browserconfig.xml.erb. Consider leveraging the helper method to handle favicon switching so that we're not relying so much on the Site&.favicon&.url() idiom; and instead going favicon&.url(). (Note this is conjecture by Jeremy)

Acceptance Criteria

Testing Instructions

Navigate to proprietor homepage. Icon should show on tab.

jillpe commented 11 months ago

This functionality is already there? See here Were there additional features you were hoping would be a part of that?

ndroark commented 11 months ago

We have that functionality for each tenant, but not for the Hyku Commons homepage itself. I don't think we actually care about superadmins having the ability to change it, we would just like to add one through the html.

jillpe commented 11 months ago

@ndroark Can you share the fav icon image with us?

ndroark commented 10 months ago

Image

laritakr commented 7 months ago

✅ Passes QA

Image