Open ndroark opened 1 year ago
This functionality is already there? See here Were there additional features you were hoping would be a part of that?
We have that functionality for each tenant, but not for the Hyku Commons homepage itself. I don't think we actually care about superadmins having the ability to change it, we would just like to add one through the html.
@ndroark Can you share the fav icon image with us?
✅ Passes QA
Summary
Pals would like to be able to have a home page favicon for [Hyku Commons[(https://hykucommons.org/) set up through html.
Tasks
The
app/helpers/hyrax_helper.rb
has afavicon
method; which does not appear to be called inapp/views/_head_tag_extras.html.erb
norapp/views/hyrax/homepage/browserconfig.xml.erb
. Consider leveraging the helper method to handle favicon switching so that we're not relying so much on theSite&.favicon&.url()
idiom; and instead goingfavicon&.url()
. (Note this is conjecture by Jeremy)favicon
helper method instead of the chained methods of the above views.Site
(e.g. we're on the proprietor page), use the hard-coded proprietor faviconAcceptance Criteria
Testing Instructions
Navigate to proprietor homepage. Icon should show on tab.