Refine account settings page to limit options for non-super admins

[jillpe]

Summary

The Account Setting page has too many options for non-super admins, and Pals would like to limit their options.

Screenshots


Hide certain settings from non-superadmins on the Account settings dashboard page as prescribed by the client.

Acceptance Criteria

A non super admin user should NOT see the following fields:

• [ ] :~contact_email~ See comments section for update
• [ ] :contact_email_to,
• [ ] :analytics_provider
• [ ] :file_acl
• [ ] :s3_bucket,
• [ ] :oai_prefix
• [ ] :oai_sample_identifier,
• [ ] :file_size_limit

Testing Instructions

Visit the options here, as a super admin and a non super admin.

super admin login: support@notch8.com => get password from 1Password non super admin login: user@example.com => testing123

Expected Behavior Before Changes

screenshot (non superadmin user)


screenshot (superadmin user)


Expected Behavior After Changes

screenshot (non superadmin user)


screenshot (superadmin user)


[jillpe]

What do you want non-super admins to see?

[ndroark]

Partially, we're not sure what some of these fields are for, and thus we're not sure what could potentially allow users to break systems by changing settings.

The ones we don't know about are:

• Analytics Provider
• File acl
• OAI prefix
• Oai sample identifier
• S3 Bucket

I think we should also limit File Size Limit to superadmin (I also notice that the text says it should be set to at least 536870912000 but the default value is only 5368709120)

[ndroark]

Given the information on ticket 778, we should add Contact Email and Contact Email To to the list of things only superadmins can access. https://github.com/scientist-softserv/palni-palci/issues/778

[jillpe]

SoftServ QA: ✅ Pass!

Logged in as a Super Admin:


Logged in as a NON Super Admin:

A non super admin user should NOT see the following fields: - [x] :contact_email - [x] :contact_email_to, - [x] :analytics_provider - [x] :file_acl - [x] :s3_bucket, - [x] :oai_prefix - [x] :oai_sample_identifier, - [x] :file_size_limit 

[ndroark]

We want to retain Contact email to for local admins. There is also an issue with some tenants having different Account settings pages (see au-archives.hykucommons.org, compare to sju-library.hykucommons.org).

[ShanaLMoore]

@ndroark What do you mean by local admins? These fields should only show to superadmins with our changes.

[ndroark]

I mean that we need to revert that change for the Contact Email To field. It should be accessible to non-super admins, since it's something they can set and change without additional configuration. See Rob's comment here https://assaydepot.slack.com/archives/C0313NKC08L/p1697499227224089?thread_ts=1697487952.830559&cid=C0313NKC08L

[ShanaLMoore]

Gotcha. For clarity of this ticket, could you list the fields that should only be displayed to superadmins? This ticket listed many fields. We currently have them defined in a constant, here cc @ndroark We did this based on this comment (and the acceptance criteria)

  SUPERADMIN_ONLY_SETTINGS = [:contact_email, :contact_email_to,
                              :analytics_provider, :file_acl, :s3_bucket,
                              :oai_prefix, :oai_sample_identifier,
                              :file_size_limit].freeze

[ndroark]

For sure, that same list without the Contact email to. So the superadmin only settings are :

:contact_email, :analytics_provider, :file_acl, :s3_bucket, :oai_prefix, :oai_sample_identifier, :file_size_limit

[ShanaLMoore]

QA RESULTS:

Tested on: https://dev.commons-archive.org/

SUPER ADMIN SHOULD SEE:

• [x] contact email
• [x] analytics provider
• [x] file acl
• [x] s3 bucket
• [x] oai prefix
• [x] oai sample identifier
• [x] file size limit

ADMIN SHOULD NOT SEE:

• [x] contact email
• [x] analytics provider
• [x] file acl
• [x] s3 bucket
• [x] oai prefix
• [x] oai sample identifier
• [x] file size limit

• [x] Non super admins can set contact email to field. shana@scientist.com => kirk.wang@scientist.com

[ndroark]

The help text for "Contact email" and "Contact email to" are reversed

[kirkkwang]

switched the hint text, will be doing a hot fix deploy soon