Fix Broken Specs - Githubissues

ref MR - https://gitlab.com/notch8/utk-hyku/-/merge_requests/109

Rspec wasn't actually running in gitlab ci, even though the check marks are green. Now that it has been reinstated, we have a lot of failing specs to resolve:

Finished in 10 minutes 26 seconds (files took 1 minute 9.23 seconds to load) 635 examples, 71 failures, 20 pending

Failed examples:

[ ] rspec ./spec/requests/catalog_controller_spec.rb:62 # CatalogController Cross Tenant Search can fetch data from other tenants cross-search-tenant can fetch all record in child tenants
[ ] rspec ./spec/features/oai_pmh_spec.rb:31 # OAI PMH Support oai interface with works present retrieves a list of identifiers
[ ] rspec ./spec/features/oai_pmh_spec.rb:25 # OAI PMH Support oai interface with works present retrieves a single record
[ ] rspec ./spec/features/oai_pmh_spec.rb:14 # OAI PMH Support oai interface with works present lists metadata prefixess
[ ] rspec ./spec/features/oai_pmh_spec.rb:19 # OAI PMH Support oai interface with works present retrieves a list of records
[ ] rspec ./spec/features/show_page_theme_spec.rb:42 # Admin can select show page theme as a repository admin sets the themes when the theme form is saved
[ ] rspec ./spec/features/show_page_theme_spec.rb:27 # Admin can select show page theme as a repository admin has a select box for the show page themes
[ ] rspec ./spec/features/show_page_theme_spec.rb:37 # Admin can select show page theme as a repository admin sets the theme to default if no theme is selected
[ ] rspec ./spec/features/show_page_theme_spec.rb:84 # Admin can select show page theme when a show page theme is selected updates the show theme when the theme is changed
[ ] rspec ./spec/features/show_page_theme_spec.rb:110 # Admin can select show page theme when a show page theme is selected renders the default partial if the theme partial is missing
[ ] rspec ./spec/features/show_page_theme_spec.rb:59 # Admin can select show page theme when a show page theme is selected renders theme notes and wireframe
[ ] rspec ./spec/features/show_page_theme_spec.rb:69 # Admin can select show page theme when a show page theme is selected renders the partials in the theme folder
[ ] rspec ./spec/controllers/hyrax/images_controller_spec.rb:35 # Hyrax::ImagesController with theming
[ ] rspec ./spec/controllers/hyrax/images_controller_spec.rb:28 # Hyrax::ImagesController#presenter initializes a presenter
[ ] rspec ./spec/features/cultural_repository_theme_spec.rb:21 # Admin can select cultural repository theme as a repository admin sets the cultural repository theme when the theme form is saved
[ ] rspec ./spec/features/cultural_repository_theme_spec.rb:38 # Admin can select cultural repository theme when the cultural repository theme is selected renders the partials in the theme folder
[ ] rspec ./spec/controllers/hyrax/generic_works_controller_spec.rb:23 # Hyrax::GenericWorksController#presenter initializes a presenter
[ ] rspec ./spec/features/institutional_repository_theme_spec.rb:18 # Admin can select institutional repository theme as a repository admin sets the institutional repository theme when the theme form is saved
[ ] rspec ./spec/features/institutional_repository_theme_spec.rb:58 # Admin can select institutional repository theme when the institutional repository theme is selected renders the stats carousel if there are more than 6 resource_types
[ ] rspec ./spec/features/institutional_repository_theme_spec.rb:35 # Admin can select institutional repository theme when the institutional repository theme is selected renders the partials in the theme folder
[ ] rspec ./spec/lib/importer/factory/image_factory_spec.rb:25 # Importer::Factory::ImageFactory when a collection already exists does not create a new collection
[ ] rspec './spec/lib/importer/factory/image_factory_spec.rb[1:3:2]' # Importer::Factory::ImageFactory without a file updates a Work with supplied metadata
[ ] rspec './spec/lib/importer/factory/image_factory_spec.rb[1:3:1]' # Importer::Factory::ImageFactory without a file creates a Work with supplied metadata
[ ] rspec './spec/lib/importer/factory/image_factory_spec.rb[1:2:1:1]' # Importer::Factory::ImageFactory with a file #run uploads the content of the file
[ ] rspec './spec/lib/importer/factory/image_factory_spec.rb[1:2:2:1]' # Importer::Factory::ImageFactory with a file when a work with the same id already exists updates metadata
[ ] rspec ./spec/features/create_image_spec.rb:41 # Create a Image a logged in user is expected to have text "Add New Image"
[ ] rspec ./spec/presenters/hyku/work_show_presenter_spec.rb:22 # Hyku::WorkShowPresenter when the work has valid doi and isbns #doi extracts the DOI from the identifiers
[ ] rspec ./spec/presenters/hyku/work_show_presenter_spec.rb:28 # Hyku::WorkShowPresenter when the work has valid doi and isbns #isbns extracts ISBNs from the identifiers
[ ] rspec ./spec/lib/active_job/queue_adapters/better_active_elastic_job_adapter_spec.rb:19 # ActiveJob::QueueAdapters::BetterActiveElasticJobAdapter#enqueue uses the configured queue
[ ] rspec ./spec/forms/hyrax/generic_work_form_spec.rb:21 # Hyrax::GenericWorkForm.model_attributes permits parameters
[ ] rspec ./spec/forms/hyrax/generic_work_form_spec.rb:5 # Hyrax::GenericWorkForm.primary_terms includes the license field
[ ] rspec ./spec/features/dc_repository_theme_spec.rb:21 # Admin can select dc repository theme as a repository admin sets the trace repository theme when the theme form is saved
[ ] rspec ./spec/features/trace_repository_theme_spec.rb:21 # Admin can select trace repository theme as a repository admin sets the trace repository theme when the theme form is saved
[ ] rspec ./spec/requests/institution_visibility_spec.rb:61 # Insitution visiblity work access as an end-user does not allow access for users of other tenants
[ ] rspec ./spec/requests/institution_visibility_spec.rb:55 # Insitution visiblity work access as an end-user allows access for users of the tenant
[ ] rspec ./spec/requests/institution_visibility_spec.rb:76 # Insitution visiblity work access when a user is invited now allows access for users of the tenant
[ ] rspec ./spec/lib/importer/factory/etd_factory_spec.rb:25 # Importer::Factory::ETDFactory when a collection already exists does not create a new collection
[ ] rspec './spec/lib/importer/factory/etd_factory_spec.rb[1:2:1:1]' # Importer::Factory::ETDFactory with a file #run uploads the content of the file
[ ] rspec './spec/lib/importer/factory/etd_factory_spec.rb[1:2:2:1]' # Importer::Factory::ETDFactory with a file when a work with the same id already exists updates metadata
[ ] rspec './spec/lib/importer/factory/etd_factory_spec.rb[1:3:1]' # Importer::Factory::ETDFactory without a file creates a Work with supplied metadata
[ ] rspec './spec/lib/importer/factory/etd_factory_spec.rb[1:3:2]' # Importer::Factory::ETDFactory without a file updates a Work with supplied metadata
[ ] rspec ./spec/controllers/hyrax/homepage_controller_spec.rb:89 # Hyrax::HomepageController#index with a document not created this second sets recent documents in the right order
[ ] rspec ./spec/controllers/hyrax/homepage_controller_spec.rb:171 # Hyrax::HomepageController#index with ir stats gets the stats
[ ] rspec ./spec/controllers/hyrax/homepage_controller_spec.rb:128 # Hyrax::HomepageController#index with featured works sets featured works
[ ] rspec ./spec/features/create_generic_work_spec.rb:42 # Create a GenericWork a logged in user
[ ] rspec ./spec/lib/importer/mods_importer_spec.rb:18 # Importer::ModsImporter#import an image creates a new image and a collection
[ ] rspec ./spec/lib/importer/mods_importer_spec.rb:37 # Importer::ModsImporter#import an image when the collection already exists adds image to existing collection
[ ] rspec ./spec/indexers/app_indexer_spec.rb:23 # AppIndexer account_cname_tesim indexer has the account_cname
[ ] rspec ./spec/features/appearance_theme_spec.rb:131 # Admin can select home page theme when a home page theme is selected renders the partials in the theme folder
[ ] rspec ./spec/features/appearance_theme_spec.rb:172 # Admin can select home page theme when a home page theme is selected renders the default partial if the theme partial is missing
[ ] rspec ./spec/features/appearance_theme_spec.rb:146 # Admin can select home page theme when a home page theme is selected updates the home theme when the theme is changed
[ ] rspec ./spec/features/appearance_theme_spec.rb:119 # Admin can select home page theme when a home page theme is selected renders theme notes and wireframe
[ ] rspec ./spec/features/appearance_theme_spec.rb:21 # Admin can select home page theme as a repository admin has a tab for themes on the appearance tab
[ ] rspec ./spec/features/appearance_theme_spec.rb:46 # Admin can select home page theme as a repository admin sets the themes when the theme form is saved
[ ] rspec ./spec/features/appearance_theme_spec.rb:41 # Admin can select home page theme as a repository admin sets the theme to default if no theme is selected
[ ] rspec ./spec/features/appearance_theme_spec.rb:29 # Admin can select home page theme as a repository admin has a select box for the home, show, and search pages themes
[ ] rspec ./spec/features/appearance_theme_spec.rb:110 # Admin can select home page theme when a search results theme is selected defaults to list view when no theme is selected
[ ] rspec ./spec/features/appearance_theme_spec.rb:67 # Admin can select home page theme when a search results theme is selected updates the search results page with the selected layout view
[ ] rspec ./spec/jobs/embargo_auto_expiry_job_spec.rb:42 # EmbargoAutoExpiryJob#reenqueue Enques an EmbargoExpiryJob after perform
[ ] rspec ./spec/jobs/embargo_auto_expiry_job_spec.rb:48 # EmbargoAutoExpiryJob#perform Expires the Embargo on a work with expired Embargo
[ ] rspec ./spec/jobs/embargo_auto_expiry_job_spec.rb:56 # EmbargoAutoExpiryJob#perform Expires embargos on file sets with expired embargos
[ ] rspec ./spec/jobs/embargo_auto_expiry_job_spec.rb:64 # EmbargoAutoExpiryJob#perform Does not expire embargo when embargo is still active
[ ] rspec ./spec/jobs/lease_auto_expiry_job_spec.rb:45 # LeaseAutoExpiryJob#reenqueue Enques an LeaseExpiryJob after perform
[ ] rspec ./spec/jobs/lease_auto_expiry_job_spec.rb:59 # LeaseAutoExpiryJob#perform Expires leases on file sets with expired leases
[ ] rspec ./spec/jobs/lease_auto_expiry_job_spec.rb:67 # LeaseAutoExpiryJob#perform Does not expire lease when lease is still active
[ ] rspec ./spec/jobs/lease_auto_expiry_job_spec.rb:51 # LeaseAutoExpiryJob#perform Expires the lease on a work with expired lease
[ ] rspec ./spec/forms/hyrax/image_form_spec.rb:22 # Hyrax::ImageForm.model_attributes permits parameters
[ ] rspec ./spec/forms/hyrax/image_form_spec.rb:6 # Hyrax::ImageForm.primary_terms includes the license field
[ ] rspec ./spec/features/feature_flag_spec.rb:30 # Admin can select feature flags as a repository admin has a setting for featured works
[ ] rspec ./spec/features/feature_flag_spec.rb:46 # Admin can select feature flags as a repository admin has a setting for recently uploaded
[ ] rspec ./spec/features/feature_flag_spec.rb:66 # Admin can select feature flags when all home tabs and share work features are turned off the page only shows the collections tab

scientist-softserv / utk-hyku

Fix Broken Specs #206