Closed laritakr closed 1 year ago
remaining terms are listed as facetable in the profile
If AllinsonFlex isn't capable of doing this, manually add them for now and create a separate ticket for AllinsonFlex to do it automatically.
facetable fields
based on most recent metadata profile:
Current facet fields in catalog_controller:
Per LaRita, indexing seems to be working correctly but the dynamic catalog behavior is not being included anywhere. ESSI is including it in their catalog controller: https://github.com/search?q=repo%3AIU-LibrariesJointDevelopment%2Fessi%20DynamicCatalogBehavior&type=code
@laritakr We were able to figure out #425 :tada: Turns out there's support for facets with allinson flex after all. With your tip, we figured out it wasn't being included. With Deon, we figured out it wasn't working because of a minor but significant typo. After correcting that, the facets appears as defined by the m3 metadata profile.
NEXT STEPS: @DeonFranklin will submit the typo fix to allinson flex. Once that gets merged, he will submit a PR that
Thanks for driving @DeonFranklin
~Needs further review:~ EDIT: This passes SoftServ QA The language issues arise from the M3 profile, not the work that was done here. So this ticket passes.
tested on:
Language
and Local Language
. I typed in Vietnamese
for Language
and English
for Language local
. When I save the form, Language: English
appears twice on the work show page and search catalog. Language: Vietnamese
doesn't appear at all. Editing the work shows that Vietnamese
is overridden with English
.@laritakr for clarification, based on what I've read for the ticket, it seems like y'all have determined how to get AllinsonFlex to do this automatically based on the m3 profile instead of having to manually add them, correct?
@kidon0011 Yes, we found indications that it should have been working, and found several small bugs that were causing the problem. So it works now. :)
Verification on production blocked until #358 resolved
related to
408
392
Todo
Ideally this work will be implemented via allinson flex. As a last resort, manually set them. Add all missing facets based on metadata profile.
Related to #426
Testing Instructions
Notes
It looks like Allinson flex has a switch statement to determine the solr suffix -
https://github.com/samvera-labs/allinson_flex/blob/ab9b353a3034c182218356c9320ebe0b6b952a79/app/services/allinson_flex/dynamic_schema_service.rb#L207-L227
AF may store what is facetable but it doesn't auto connect anything to the catalog controller for it to facet automatically.
Maybe check if ESSI already have an implementation for this?