scientist-softserv / utk-hyku

Other
6 stars 0 forks source link

🎁Add facets for "facetable" properties #425

Closed laritakr closed 1 year ago

laritakr commented 1 year ago

related to

Todo

Ideally this work will be implemented via allinson flex. As a last resort, manually set them. Add all missing facets based on metadata profile.

Related to #426

Testing Instructions

Notes

It looks like Allinson flex has a switch statement to determine the solr suffix -
https://github.com/samvera-labs/allinson_flex/blob/ab9b353a3034c182218356c9320ebe0b6b952a79/app/services/allinson_flex/dynamic_schema_service.rb#L207-L227

AF may store what is facetable but it doesn't auto connect anything to the catalog controller for it to facet automatically.

Maybe check if ESSI already have an implementation for this?

jillpe commented 1 year ago

remaining terms are listed as facetable in the profile

ShanaLMoore commented 1 year ago

If AllinsonFlex isn't capable of doing this, manually add them for now and create a separate ticket for AllinsonFlex to do it automatically.

laritakr commented 1 year ago

facetable fields based on most recent metadata profile:

Current facet fields in catalog_controller: Screenshot 2023-07-07 at 3 58 24 PM

ShanaLMoore commented 1 year ago

Per LaRita, indexing seems to be working correctly but the dynamic catalog behavior is not being included anywhere. ESSI is including it in their catalog controller: https://github.com/search?q=repo%3AIU-LibrariesJointDevelopment%2Fessi%20DynamicCatalogBehavior&type=code

ShanaLMoore commented 1 year ago

@laritakr We were able to figure out #425 :tada: Turns out there's support for facets with allinson flex after all. With your tip, we figured out it wasn't being included. With Deon, we figured out it wasn't working because of a minor but significant typo. After correcting that, the facets appears as defined by the m3 metadata profile.

NEXT STEPS: @DeonFranklin will submit the typo fix to allinson flex. Once that gets merged, he will submit a PR that

  1. has the module included in the catalog controller
  2. updates allinson flex to pull in the fix

Thanks for driving @DeonFranklin

DeonFranklin commented 1 year ago
DiemBTran commented 1 year ago

~Needs further review:~ EDIT: This passes SoftServ QA The language issues arise from the M3 profile, not the work that was done here. So this ticket passes.

tested on:

Testing Instructions

Facetable properties appear in search facets ![Book 2023-07-18 🎁Add facets for facetable properties #425 ID 6dc76370-9865-46ef-b49c-fcdd4c56e429 Hyku 2023-07-18 at 2 40 11 PM](https://github.com/scientist-softserv/utk-hyku/assets/29311858/67542ddb-e7a0-4456-825a-3bbb784ceb77) ![Index Catalog Hyku 2023-07-18 at 2 40 25 PM](https://github.com/scientist-softserv/utk-hyku/assets/29311858/970f41be-7c4d-4412-abce-7731ff7b82ba)
josh-morgan117 commented 1 year ago

@laritakr for clarification, based on what I've read for the ticket, it seems like y'all have determined how to get AllinsonFlex to do this automatically based on the m3 profile instead of having to manually add them, correct?

laritakr commented 1 year ago

@kidon0011 Yes, we found indications that it should have been working, and found several small bugs that were causing the problem. So it works now. :)

jillpe commented 1 year ago

Verification on production blocked until #358 resolved