scientist-softserv / utk-hyku

Other
6 stars 0 forks source link

🎁 Include closed captions / transcripts in manifest #442

Open kirkkwang opened 1 year ago

kirkkwang commented 1 year ago

Story

UTK want the transcripts of A/V works on their IIIF manifests.

related to:

Acceptance Criteria

Screenshots / Video

image

Testing Instructions and Sample Files

Notes

At this point in time the video may not be viewable unless the representative and thumbnail are set manually in the work's edit page.

jillpe commented 1 year ago

SoftServ QA:

csv imported:

rfta_test_with_attachments_video.csv

Import URL

/manifest.json

Annotations: only english is present in the annotations field

Image

jillpe commented 1 year ago

related to

ShanaLMoore commented 1 year ago

altered csv: 442.csv

the original CSV's Video was referencing identifiers to collections that didn't exist, which was the reason the create relationships jobs kept failing.

For some reason, the spanish transcript files did not import which is the reason Jill didn't see it in the manifest.

ShanaLMoore commented 1 year ago

@jillpe

I deleted the original importer and the video file it created, and reimported the following altered file: 442.csv

The file that you used was trying to reference a collection that didn't exist, so the create relationship jobs never succeeded. I'm thinking about a way we can raise a better error, but that shouldn't stop you from redoing QA. Maybe try this again using a different tenant if you want to retest from scratch?

Updated importer: https://dc.utk-hyku-staging.notch8.cloud/importers/135?locale=en

I made sure all entries were successful:

Work entries: image

FileSet entries: image

I'm not sure if I should expect the video to play in the UV at this point, but that doesn't seem to be an acceptance criteria of the ticket anyways.

edit: It plays just fine in chrome. My above comment wasn't playing in firefox. 🤔

Afterwards I was able to visit the video record's /manifest.json and see the spanish transcript in there:

image

auto generated thumbnail:

image
jillpe commented 1 year ago

SoftServ QA: Pass

First Test csv: [rfta_test_with_attachments_video.csv](https://github.com/scientist-softserv/utk-hyku/files/11909342/rfta_test_with_attachments_video.csv) [Importer URL](https://qa.utk-hyku-staging.notch8.cloud/importers/36?locale=en) [Manifest URL](https://qa.utk-hyku-staging.notch8.cloud/concern/videos/1f0e2ba1-acf2-4508-8b3c-9aa331e984df/manifest.json) - Manifest shows 1 language (es) in the `annotations` field which is correct.
Second Test csv: [rfta_test_with_attachments_video.1.csv](https://github.com/scientist-softserv/utk-hyku/files/11909344/rfta_test_with_attachments_video.1.csv) [Importer URL](https://qa.utk-hyku-staging.notch8.cloud/importers/36?locale=en) [Manifest URL](https://qa.utk-hyku-staging.notch8.cloud/concern/videos/b641088a-2e95-4735-86d3-b9f19f0867bc/manifest.json) - shows 2 languages (en and es), which is correct ![Image](https://github.com/scientist-softserv/utk-hyku/assets/84697174/c836eec7-39b0-44a7-95d2-ff06726bd8ee)
markpbaggett commented 1 year ago

Looks good here:

https://dc.utk-hyku-staging.notch8.cloud/concern/videos/febc6b41-d998-47ab-9732-ac09fd8168f2/manifest

and here:

https://dc.utk-hyku-staging.notch8.cloud/concern/audios/b648cfc2-b87f-43e1-ac85-a87a6d32978d/manifest

jillpe commented 1 year ago

Verification on production blocked until #358 resolved

jillpe commented 6 months ago

UTK will verify this when they start bringing in audio imports

markpbaggett commented 4 months ago

@jillpe and @kirkkwang something odd is happening here in production. Take a look at Bopp, William F.: WWII Oral History - Part 2. It clearly has captions:

Image

Also, those captions look like they are modeled correctly in the manifest:

Image

But when you access them, you get a Rails error:

Image

Any idea what's happening here?

kirkkwang commented 4 months ago

@markpbaggett that's very strange why it doesn't show up, here's the vtt download that it should pull from https://dc.utk-hyku-production.notch8.cloud/downloads/74b91038-3fc3-436d-9d44-87a308dea6c7

I don't think that id that you clicked on ever worked in hyrax applications, but the link above is where the viewer should pull the caption from which downloads, but I'm not sure off the top of my head why it's not going into the viewer

I do see this in the console:

image

The strange thing is that could have sworn this was working before.

image
josh-morgan117 commented 1 month ago

I don't see the captions appearing in the viewer when I click on "Captions in English".

Also, with this example we are still seeing the language as a URI.