scientist-softserv / utk-hyku

Other
6 stars 0 forks source link

Search Results Page is responsive and mobile friendly #478

Open ShanaLMoore opened 1 year ago

ShanaLMoore commented 1 year ago

Summary

Header Logo at 375 x 667 The log and 'libraries' line breaks at this dimension. Screen Shot 2023-07-19 at 12 38 09 PM
"Digital Collections" Header The "Digital Collections" heading is cut off at the top. It looks like there needs to be more padding on the bottom as well (under "our collections") Screen Shot 2023-07-19 at 1 25 37 PM
Search Bar Search Bar appears cramped and user cannot read "Search Digital Collections" Screen Shot 2023-07-19 at 1 26 54 PM
Page Number and Sort The sorting options, number of items per page option, and link/grid option have a line break as well. It would look more cohesive if these items could be centered or all on one line. Screen Shot 2023-07-19 at 1 31 53 PM
Expanded language options When a user clicks on the options for the site languages the header is does not expand with it. See screenshots below. Screen Shot 2023-07-19 at 1 36 40 PM
Expanded login options When a user clicks on the options for the login the header is does not expand with it. See screenshots below. image

Acceptance Criteria

Testing Instructions

Navigate to the Search Results Page and ensure the following are correct:

Notes

also closes https://github.com/scientist-softserv/utk-hyku/issues/480

jillpe commented 1 year ago

SoftServ QA: Needs Rework

Screen Shot 2023-07-31 at 2 49 11 PM

Screen Shot 2023-07-31 at 2 52 01 PM

kirkkwang commented 1 year ago

Clients are okay with Search bar content slightly cut-off at certain widths

jillpe commented 1 year ago

Clients confirmed search bar is okay in client meeting 2023-08-01. This passes SoftServ QA

josh-morgan117 commented 1 year ago

Can we get the alignment fixed on these so there's not wonky spacing? Image

ShanaLMoore commented 1 year ago

TIMEBOX: 2 HRS

kirkkwang commented 1 year ago

@kidon0011 I'm looking into this spacing issue, do you have the link to this example?

kirkkwang commented 9 months ago

EDIT: never mind i found it!

@kidon0011 @jillpe this only thing i was able to find on production was this that matches the text, i cannot replicate to fix it, can I get the specific work you're looking at?

Image https://digitalcollections.lib.utk.edu/concern/images/40b0c17e-32ff-4deb-a1c5-d935bea81d15

jillpe commented 9 months ago

SoftServ QA: ✅

Image

josh-morgan117 commented 9 months ago

For this one I found an issue where if you are signed in and get the "All " dropdown in the search box, it hovers behind the text below it. Mark and I played around in the console and found a solution by adding a z-index of -1, at least in this case but maybe not all views.

Image

Image

kirkkwang commented 9 months ago

@kidon0011 cool thanks for the breadcrumbs, I ended up making adjustments at a higher level to make sure it worked for all cases (as far as I can tell)

image
josh-morgan117 commented 9 months ago

This card passes with that fix. Thanks, @kirkkwang