scientist-softserv / utk-hyku

Other

6 stars 0 forks source link

Sort by options for collection items are only for date uploaded/modified (preferred dates: Publication, Creation) #650

Open jillpe opened 3 months ago

jillpe commented 3 months ago

Summary

reference: https://docs.google.com/spreadsheets/d/1XbfCosfI_P3N2JVYldD28p6Ca6AxNRbAOKbOcp1GRgo/edit?gid=0#gid=0

Example link Example screenshot

This is relevant to an IR but is not helpful to sorting our results by metadata fields (date of publication etc.) The sort by title option doesn't seem to make any difference in the display of collection items? We need to be able to sort by Solr fields or something similar

Acceptance Criteria

[x] The user can sort search results by Publication
[x] The user can sort search results by Creation

⚠️ NOTE ⚠️

This change does require a reindex to take effect.

Testing Instructions

Click search button or visit this staging URL
Click on Sort by relevance dropdown menu
Select date published ascending
Select date published descending
Select date created ascending
Select date created descending

orangewolf commented 3 months ago

recommend talking this through with Kirk, Kait or Shana before digging in to it. also be aware that creation and publication have 2 versions and the "machine readable" one is the only one you can sort by

jillpe commented 2 months ago

SoftServ QA Observations

Does not appear to be changing order based on publication or creation date

https://github.com/user-attachments/assets/bca85bd4-f79c-48ab-b5ce-6f7d2093b0a0

kirkkwang commented 2 months ago

@sjproctor I think i know what's wrong, we need to call #first on the dates because they are actually multiples. https://github.com/scientist-softserv/utk-hyku/blob/main/app/indexers/collection_indexer.rb#L16-L17

ShanaLMoore commented 2 months ago

QA RESULTS: ⚠ Requires Review

tested on STAGING

[ ] A user can sort by publication date ❌
- [ ] No changes occur between publication date asc and publication date dsc
- [ ] cc @sjproctor @kirkkwang Has staging been reindexed since the last changes to fix this?
[x] A user can sort by creation date ✅

ShanaLMoore commented 2 months ago

QA RESULTS: ✅ PASS

Kirk uploaded a new m3 profile to add publication_date to the objects. Now the sort is working as expected.

josh-morgan117 commented 2 days ago

@jillpe Looks like this one has been deployed to production and works. Before I move it to the end, I just want to make sure it's not sitting in Client QA for another reason?