scientist-softserv / west-virginia-university

West Virginia University
0 stars 0 forks source link

🐛 Make dropdowns on catalog#index work properly #131

Closed kirkkwang closed 1 year ago

kirkkwang commented 1 year ago

Story

The bootstrap dropdown menu was not working properly and removing the require fixes the issue. I think maybe something else that was also requiring it which caused a conflict.

Screenshots / Video

image

Ref:

jeremyf commented 1 year ago

Further sleuthing, we introduced this https://github.com/scientist-softserv/west-virginia-university/commit/3e10fb1769539a59c8478354f390993f1fe83c60

kirkkwang commented 1 year ago

Further sleuthing, we introduced this 3e10fb1

Good find, I'm fine with keeping it in if it's supposed to be there, but what I'm observing is that even in a deployed environment such as here

https://congressarchivesdev.lib.wvu.edu/?utf8=%E2%9C%93&search_field=all_fields&q=

I'm unable to click on the dropdown so something is broken both locally and deployed. I'm definitely opened to other suggestions.

ShanaLMoore commented 1 year ago

How do the bulkrax fields perform with this change? Summer's commit shows that it was added for bulkrax.

kirkkwang commented 1 year ago

How do the bulkrax fields perform with this change? Summer's commit shows that it was added for bulkrax.

Yeah looks like it doesn't work, so at the moment it's either the dropdown menus work or the Bulkrax tables work but not both, I'll play with the requires to see if there's something else we need

kirkkwang commented 1 year ago

@jeremyf @ShanaLMoore I updated Bulkrax to add javascript to make the tabs work. Ultimately I think we should remove bootstrap because we introduced specifically for Bulkrax and thus I think the fix should be in Bulkrax and not this application.