search

scientist2009 / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

CPDF_ICCBasedCS::GetDefaultValue() doesn't override and is unused. #170

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Looks to be a signature mismatch between:
CPDF_ICCBasedCS::GetDefaultValue(int i, FX_FLOAT& min, FX_FLOAT& max) const
CPDF_ColorSpace::GetDefaultValue(int iComponent, FX_FLOAT& value, FX_FLOAT& 
min, FX_FLOAT& max) const

Which was noticed while adding some "overrides".  Not clear what the default 
value should be or if fixing this will break anything.

Original issue reported on code.google.com by tsepez@chromium.org on 13 Jun 2015 at 12:32

GoogleCodeExporter commented 9 years ago 
Hey Jun, can you ping your developers and see if they have an opinion.  Thanks.

Original comment by tsepez@chromium.org on 13 Jun 2015 at 12:37

GoogleCodeExporter commented 9 years ago 
Same with CPDF_IndexedCS::GetDefaultValue()

Original comment by tsepez@chromium.org on 13 Jun 2015 at 12:38

GoogleCodeExporter commented 9 years ago 
https://pdfium.googlesource.com/pdfium/+/ea44bd064a86679a47a7265020f997d6e3b8833
6 implements a "fix" for this, so long as 0 is a good default.

Original comment by tsepez@chromium.org on 16 Jun 2015 at 11:20