scientistproject / Scientist.net

A .NET library for carefully refactoring critical paths. It's a port of GitHub's Ruby Scientist library
MIT License
1.46k stars 95 forks source link

Actions for testing & coverage #137

Open JoshHiles opened 2 years ago

JoshHiles commented 2 years ago

Description

As a maintainer, I want testing & coverage ran on PR’s, So that we are sure the code is ready for release

Acceptance Criteria

marblekirby commented 2 years ago

We can add coverlet for code coverage.

I can create this github action that will run the unit tests and coverage.

marblekirby commented 2 years ago

Happy to be assigned this

What i understand that we need:

JoshHiles commented 2 years ago

Happy to be assigned this

What i understand that we need:

* Create new Xunit project on the core-rewrite branch

* Add new action to run the Xunit tests + coverlet coverage

* Add new status badge for above action

Sounds good to me, i will create a 3.0.0 branch so you can fork the repo and create PR's against that

marblekirby commented 2 years ago

grand - do we want to create new project/solution in the core-rewrite/3.0.0 for me to add unit tests. And then include in this action a build of that new Scientist.Net project before testing and coverage

JoshHiles commented 2 years ago

I've pushed up branch 3.0.0 You can remove the code thats already in the scientist folder i forgot i was having a look and pushed it up

marblekirby commented 2 years ago

sure thank you 👍 👍

marblekirby commented 2 years ago

forked and removed the existing code, installed latest coverlet and XUnit. Will create github action and get PR up for this tomorrow.