Issue #137 - Github action for test and coverage

scientistproject / Scientist.net

A .NET library for carefully refactoring critical paths. It's a port of GitHub's Ruby Scientist library

MIT License

1.46k stars 95 forks source link

Issue #137 - Github action for test and coverage #146

Closed marblekirby closed 3 years ago

marblekirby commented 3 years ago

PR contains alot of changes to build files - wasnt sure if it was reading from master/main branch's .github/workflows or the 3.0.0 branch's .github/workflow

Issue

This should resolve Issue #137

Changes

commented out code so project would build
added new github action for unit test and coverage
added coverlet to unit test project

marblekirby commented 3 years ago

@JoshHiles @M-Zuber do I need to make any changes other than renaming the file?

M-Zuber commented 3 years ago

Could you explain a bit more what this means: commented out code so project would build?

marblekirby commented 3 years ago

the commented out code was commenting out the existing project code that was broken

marblekirby commented 3 years ago

Hi is this ready to be merged or do i need to fix PR for the failing CI build?

JoshHiles commented 3 years ago

Hi is this ready to be merged or do i need to fix PR for the failing CI build?

i dont think you need to fix the appveyor action, this creates a new release for nuget i do believe so its ok if it fails. we have a seperate issue to get that solved #141

paulbreen commented 3 years ago

yes, it is available to merge. we are happy to press the button?