Unit Test ReadMe update

[mnreggi]

Hello awesome Team! I don't know if this is the best way of asking this, but through this PR https://github.com/github/Scientist.net/pull/108, you added the option for IoC/Dependency Injection. The readme doesn't say anything about running UnitTest on classes that use Scientist.

For Example (This case is using the static approach, but my case uses the Injected one .Experiment):

public decimal GetUserStatistic(IUser user)
{
    return Scientist.Science<decimal>("new-statistic-calculation", experiment =>
    {
        experiment.RunIf(() => user.IsTestSubject);

        experiment.Use(() => CalculateStatistic(user));
        experiment.Try(() => NewCalculateStatistic(user));
    });
}

• Let's say that I have UnitTests for CalculateStatistic(user), how can I test them now with Scientist?
• Is the only way of setting CalculateStatistic(user) as public and have my Unit tests there?
• What if I want to run the actual GetUserStatistic method to test Scientis?

Thanks!

[JoshHiles]

Thank you for getting in touch!

Your first point (and anyone correct me on any of the answers below, too busy doing devops & angular ☹️), your unit tests for CalculateStatistic(user) will still stay the same as that is a unit of code (method) which needs testing independently.

For the method CalculateStatistic(user) it depends on where it lives as to whether or not it needs to be private or public, if its in the same class it can be private or public if its in another class. In regards to unit testing a private method you can use the following i think

Class target = new Class();
PrivateObject obj = new PrivateObject(target);
var retVal = obj.Invoke("PrivateMethod");
Assert.AreEqual(expectedVal, retVal);

You can run the GetUserStatistic() method but as far as unit testing goes, you would mock out the methods CalculateStatistic() & NewCalculateStatistic() because those are seperate unit's of code.

Hopefully i've digested what you said correctly & answered your questions! If anyone else can comment just to confirm or tell me im chatting out my backside then feel free 😄

[mnreggi]

Legend! Thanks for that, appreciate the quick response.