scientistproject / Scientist.net

A .NET library for carefully refactoring critical paths. It's a port of GitHub's Ruby Scientist library
MIT License
1.46k stars 95 forks source link

Build scripts #41

Closed davezych closed 8 years ago

davezych commented 8 years ago

Build script + nuget package creation. Used FAKE, which finds the local DNVM (available in appveyor), downloads the correct runtime version, builds the project, runs tests, generates package(s).

Things to note:

davezych commented 8 years ago

@Haacked I just realized the version numbering I have set up still won't allow to specify only one place. The goal was to support:

The way it's set up now will force us to set both the release notes and the project.json version (to add/remove the -* build number version). For "official" releases we'd have to remove that asterisk.

Unless you have any good ideas, I don't think it's really necessary to have build number versions. I can remove that and we can leave version numbers to the readme.

haacked commented 8 years ago

@davezych Just a clarification, with SemVer, the part after the - is the prerelease part. So we have:

MAJOR.MINOR.PATCH-prerelease-name#buildstamp

For example,

1.0.0-alpha#20150226

So we could have the build stamp (aka build number) be supplied by DNX, but everything else by the README.

I don't think it's really necessary to have build number versions. I can remove that and we can leave version numbers to the readme.

Having said all that, I'm fine with this plan. Let's keep it as simple as possible and only do things when we absolutely need them. :+1:

davezych commented 8 years ago

@Haacked

Just a clarification, with SemVer, the part after the - is the prerelease part.

Right. I forgot specifically what it was called. My point was, though, that leaving the prerelease part in there and having it supplied by dnx means we still need to maintain both versions, otherwise all of our packages will be prerelease until we update the version in the project.json. "Updating the version" would just mean removing -* but still, it's another thing to do.

We can't do this at this point because 1.0.0-alpha is already up on NuGet.

Ah, right. I "reverted" the version in project.json and release notes to 1.0.0-alpha and left off the dnx build number. As you said, we can add it if we need it.