search

scientistproject / Scientist.net

A .NET library for carefully refactoring critical paths. It's a port of GitHub's Ruby Scientist library
MIT License
1.46k stars 95 forks source link

Added the ability to track and manage exceptions during an experiment. Fixed #55. #56

Closed joncloud closed 8 years ago

joncloud commented 8 years ago

@Haacked should be good to go.

haacked commented 8 years ago

Looks good to me. I haven't had a chance to try it out. @davezych do you have any feedback before I merge?

davezych commented 8 years ago

I don't have time to pull it down and try it but it looks good on paper.

As a note for the future, the ExperimentInstance constructor is getting a bit unwieldy - there's what, 10 parameters there now? We might want to think about somehow cleaning that up sometime.

haacked commented 8 years ago

As a note for the future, the ExperimentInstance constructor is getting a bit unwieldy - there's what, 10 parameters there now? We might want to think about somehow cleaning that up sometime.

Indeed.

haacked commented 8 years ago

Nice work @joncloud!