search

scientistproject / Scientist.net

A .NET library for carefully refactoring critical paths. It's a port of GitHub's Ruby Scientist library
MIT License
1.46k stars 95 forks source link

Created settings class to consolidate constructor for ExperimentInstance<T>. #58

Closed joncloud closed 8 years ago

joncloud commented 8 years ago

Fixed #57.

haacked commented 8 years ago

@davezych any thoughts on this?

davezych commented 8 years ago

I like this better than any of the alternatives you mentioned. Multiple constructor overloads don't really make sense because this is only called internally/that just mucks up things even more, and I don't see much value in creating a builder over just instantiating/passing settings in.

:+1:

haacked commented 8 years ago

Agreed. I forgot that the end-user never actually creates this.

haacked commented 8 years ago

Thanks @joncloud! This is nice. :)