search

scientistproject / Scientist.net

A .NET library for carefully refactoring critical paths. It's a port of GitHub's Ruby Scientist library
MIT License
1.46k stars 95 forks source link

Added new tests for experiment without Try #73

Closed arntj closed 8 years ago

arntj commented 8 years ago

Added new test to ensure that experiment returns correctly even without any candidate. Also added tests to verify that the Clean, RunIf and Enabled delegates are not run and no publish is done if there are no candidates.

haacked commented 8 years ago

Looks good! One minor nit about a test method name. Also, I merged some changes in master that conflict with this. You'll either need to rebase this against master and force push to your branch OR just merge upstream master in your branch.

arntj commented 8 years ago

@Haacked Thanks for your suggestions. I've merged the latest changes and changed the method name as you suggested. :thumbsup:

haacked commented 8 years ago

Thanks!

selfie-0