scientistproject / Scientist.net

A .NET library for carefully refactoring critical paths. It's a port of GitHub's Ruby Scientist library
MIT License
1.46k stars 95 forks source link

Build script fails to run tests with dotnet cli preview5 (latest) #85

Closed joncloud closed 7 years ago

joncloud commented 7 years ago

It looks like the latest version of dotnet cli requires a different set of parameters in order to run the unit tests.

A couple of ideas:

Another thing that should probably be updated is that if the dotnet test command fails it should fail the build instead of allowing it to pass without checking tests.

Sample output from appveyor:

.\tools\dotnet\dotnet.exe test .\test\Scientist.Test\
Couldn't find a project to run test from. Ensure a project exists in C:\projects\scientist-net.
Or pass the path to the project
Finished Target: RunTests
haacked commented 7 years ago

Specify -Version 1.0.0-preview2-003121 when downloading dotnet cli

I like that idea as that should work immediately while we continue to work on #71 right?

Another thing that should probably be updated is that if the dotnet test command fails it should fail the build instead of allowing it to pass without checking tests.

Agreed.

joncloud commented 7 years ago

Yup - we can definitely work on these in conjunction.

joncloud commented 7 years ago

This was fixed on #86. It looks like I didn't use the keyword for closing the issue in the commit message.